Map resolved enums into scalar ABI - #80
Merged
Merged
Conversation
Add immutable caller-supplied enum mappings and project enum leaves as canonical class paths with one-based source ordinals. Validate mappings atomically while retaining fail-closed behavior for unmapped required enums.
jscott3201
commented
Aug 24, 2026
jscott3201
left a comment
Owner
Author
There was a problem hiding this comment.
Cycle 1 consolidated review — PASS at 55a6e088c356e878a9e9ae204b78bbc7d8f507f1.
Both independent reviewers found no blocker, major, or deferred minor finding. Mapping validation is atomic and deterministic; default fail-closed behavior, inactive connector omission, primitive/alias behavior, and the internal-only boundary are preserved.
Exact-head build and verify checks are green; deploy is skipped as configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The successful regression is grounded on
Buildings.Controls.OBC.ASHRAE.G36.Types.HeatingCoilat both pinned Buildings revisions (None,WaterBased,Electric) and the enum representation at the exact Engine pin. Caller mappings remain reviewed internal input; they do not perform source verification or establish a public compatibility/provenance contract.Public schemas, persisted mappings, scalar names/IRIs, source maps, graph/CXF generation, production routines, registries, and Engine or Studio changes remain deferred.
Validation
python3 -m unittest tools.lint.tests.test_routine_resolution tools.lint.tests.test_routine_scalar_abi -v(36 tests)python3 -m unittest discover -s tools/lint/tests -v(141 tests, pinned schema environment)python3 tools/lint/routine_schemas.pypython3 tools/lint/routine_semantics.pypython3 tools/lint/routines.pycargo test --manifest-path tools/verify/Cargo.toml(11 tests)cargo run --quiet --manifest-path tools/verify/Cargo.toml -- --routinescargo run --quiet --manifest-path tools/verify/Cargo.toml -- --allpython3 -m unittest discover -s tools/dataset_harness/tests -v(32 tests)verify.ymlpython3 tools/book/generate.py && mdbook build bookwith no tracked generated changesgit diff --check