Add inventory-anchored scalar source claims - #82
Merged
Conversation
Add an internal projection from named scalar rows to caller-claimed Modelica members anchored to exact G36 inventory locators. Validate pins, inventory shape, claim use, and owner bindings atomically, then derive reverse lookups from frozen ordered forward rows.
jscott3201
commented
Aug 24, 2026
jscott3201
left a comment
Owner
Author
There was a problem hiding this comment.
Immutable review cycle 1 targeted f66d44880a0da41f895f93f01aac118c00e9af24.
Both standard review lenses are blocker/major-clean. No findings were deferred. The verify and book checks completed successfully on the reviewed head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inventory membership verifies the snapshot, path, and blob only. Class and member names remain caller claims; this change does not parse Modelica declarations or define a public or persisted source map.
Schemas, registries, production routines, source spans, dependency closure, graph/CXF generation, semantic joins, and Engine or Studio changes remain deferred.
Validation
python3 -m unittest tools.lint.tests.test_routine_resolution tools.lint.tests.test_routine_scalar_abi tools.lint.tests.test_routine_scalar_names tools.lint.tests.test_routine_scalar_source_claims -v(63 tests)python3 -m py_compile tools/lint/routine_scalar_source_claims.py tools/lint/tests/test_routine_scalar_source_claims.pypython3 -m unittest discover -s tools/lint/tests -v(168 tests, pinned schema environment)python3 tools/lint/routine_schemas.pypython3 tools/lint/routine_semantics.pypython3 tools/lint/routines.pycargo test --manifest-path tools/verify/Cargo.toml(11 tests)cargo run --quiet --manifest-path tools/verify/Cargo.toml -- --routinescargo run --quiet --manifest-path tools/verify/Cargo.toml -- --allpython3 -m unittest discover -s tools/dataset_harness/tests -v(32 tests)verify.ymlpython3 tools/book/generate.py && mdbook build bookwith no tracked generated changesgit diff --check