feat(routines): check G36 source declarations - #84
Merged
Conversation
Pin Rumoca's parser crates to one exact revision and verify the release TrimAndRespond and HeatingCoil declarations after source-inventory validation.
jscott3201
commented
Aug 24, 2026
jscott3201
left a comment
Owner
Author
There was a problem hiding this comment.
Cycle 1 reviewed immutable head fbb45812b97579cb71a90a5b627e7d7de4c8f942 against base 1c9559f873ff085da52dd040982b4d498f4d17cb.
Both standard reviewers are blocker/major-clean. No findings or deferred PR-introduced issues were confirmed. The verify and build checks passed on the reviewed head.
PASS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
880ff2482dd83595425ead5963505d2100e083f1TrimAndRespondclass/member declarations andHeatingCoilenum order from parsed syntaxBoundary
This is syntax-level declaration evidence for two fixed release files. The preceding inventory gate proves checkout identity and blob membership. This change does not establish dependency closure, inherited members, semantic type resolution, graph generation, deployment, or a persisted source-map contract.
Validation
cargo test --locked --manifest-path tools/verify/Cargo.tomltools/verify/target/debug/cxf-verify --g36-declarations /path/to/release-checkouttools/verify/target/debug/cxf-verify --routinesThe parser dependency adds 127 lockfile packages and increases cold Rust build time.