refactor(routines): extract declaration compiler crate - #88
Merged
Conversation
jscott3201
commented
Aug 24, 2026
jscott3201
left a comment
Owner
Author
There was a problem hiding this comment.
Cycle 1 — exact head 3f30f176972621d8b688b0f99d8ea40a4ea59fe1
PASS: both independent reviewers found no blocker/major findings and no deferred minor observations. The declaration implementation is a byte-for-byte move, the verifier API/CLI call path and binary location are preserved, and the standalone package has no engine/path/build dependency. Local focused and full gates passed. Merge eligibility remains conditioned on the in-progress exact-head verify check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ocl-routine-compilerpackage.cxf-verify's public re-export, CLI behavior, diagnostics, and binary path unchanged through a sibling path dependency.Validation
ocl-routine-compiler: 10 testscxf-verify: 12 tests