feat(routines): add typed Rust source-claim projection - #92
Conversation
jscott3201
left a comment
There was a problem hiding this comment.
Immutable review cycle 1 — PASS
Reviewed dcc99033b5fa0a6c0e10e6ab71146ad8891a8f74...ae9f55ad5ac75e868f8750828219ca38390eea1c with the holistic and dataflow lenses. No blocker or major findings were confirmed. The typed inventory validation, role-isolated path/blob membership, owner/class/member joins, deterministic atomic diagnostics, detached output, and lookup behavior preserve the intended scope and invariants.
Exact-head build and verify checks are green. Local focused and full gates also passed.
Deferred nonblocking observation: unknown Rust lookups use Option while the existing Python helper raises KeyError; this is an idiomatic API-shape difference, not a correctness defect, and requires no change in this PR.
Summary
Validation
Scope boundary
Inventory membership proves only the exact pinned snapshot path and Git blob. Modelica class and member identities remain caller claims; this PR does not parse declarations or add JSON/I/O, persisted source maps, bound-scalar joins, or runtime artifacts.