Skip to content

feat(routines): add typed Rust source-claim projection - #92

Merged
jscott3201 merged 1 commit into
mainfrom
feat/rust-source-claims
Aug 24, 2026
Merged

feat(routines): add typed Rust source-claim projection#92
jscott3201 merged 1 commit into
mainfrom
feat/rust-source-claims

Conversation

@jscott3201

Copy link
Copy Markdown
Owner

Summary

  • add typed in-memory G36 inventory, pin, class-claim, and member-binding contracts to the Rust routine compiler
  • validate the complete named-scalar-to-source join without filesystem, JSON, declaration, persistence, or runtime coupling
  • project detached parameter and connector source-claim rows with forward and derived reverse lookups

Validation

  • cargo fmt --manifest-path tools/routine-compiler/Cargo.toml -- --check
  • cargo test --locked --manifest-path tools/routine-compiler/Cargo.toml
  • cargo clippy --locked --manifest-path tools/routine-compiler/Cargo.toml --all-targets --all-features -- -D warnings
  • 189 routine/lint unit tests plus production schema, semantic, catalog, point, registry, and SVG lints
  • G36 inventory check: 431 release files and 693 development files
  • G36 release declaration conformance
  • tools/verify tests, --routines, and --all
  • 32 dataset harness tests

Scope boundary

Inventory membership proves only the exact pinned snapshot path and Git blob. Modelica class and member identities remain caller claims; this PR does not parse declarations or add JSON/I/O, persisted source maps, bound-scalar joins, or runtime artifacts.

@jscott3201 jscott3201 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Immutable review cycle 1 — PASS

Reviewed dcc99033b5fa0a6c0e10e6ab71146ad8891a8f74...ae9f55ad5ac75e868f8750828219ca38390eea1c with the holistic and dataflow lenses. No blocker or major findings were confirmed. The typed inventory validation, role-isolated path/blob membership, owner/class/member joins, deterministic atomic diagnostics, detached output, and lookup behavior preserve the intended scope and invariants.

Exact-head build and verify checks are green. Local focused and full gates also passed.

Deferred nonblocking observation: unknown Rust lookups use Option while the existing Python helper raises KeyError; this is an idiomatic API-shape difference, not a correctness defect, and requires no change in this PR.

@jscott3201
jscott3201 merged commit e40f216 into main Aug 24, 2026
3 checks passed
@jscott3201
jscott3201 deleted the feat/rust-source-claims branch August 25, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant