Skip to content

feat(routines): check typed Rust declaration syntax - #95

Merged
jscott3201 merged 1 commit into
mainfrom
feat/rust-declaration-syntax-checks
Aug 24, 2026
Merged

feat(routines): check typed Rust declaration syntax#95
jscott3201 merged 1 commit into
mainfrom
feat/rust-declaration-syntax-checks

Conversation

@jscott3201

Copy link
Copy Markdown
Owner

Summary

  • add an in-memory checker for declaration requirements and supplied Modelica source bytes
  • verify each source against its claimed legacy Git blob ID, then parse each required document once
  • require exact direct class identity, direct public members, and parameter variability
  • reject malformed, duplicate, missing, unused, and resource-limit inputs with sorted atomic diagnostics

Scope

The checker deliberately does not claim inventory or tree membership, inheritance resolution, class kind, declared type resolution, dependency resolution, persisted evidence, or runtime CXF behavior. Rumoca remains an in-process parser without hard time or stack isolation.

Validation

  • cargo fmt --manifest-path tools/routine-compiler/Cargo.toml -- --check
  • cargo test --locked --manifest-path tools/routine-compiler/Cargo.toml (89 passed)
  • cargo clippy --locked --manifest-path tools/routine-compiler/Cargo.toml --all-targets -- -D warnings
  • full Python lint suite (189 passed) and production lints
  • G36 source inventory (431 release / 693 development files)
  • G36 declaration, routine, verifier, and full scenario gates
  • dataset harness (32 passed) and replay assertions
  • generated book build

@jscott3201 jscott3201 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cycle 1 consolidated review: PASS at 59e56f95fbaee980ce111938f4b7e9821f4701a3.

Both independent reviewers were blocker/major-clean. No confirmed findings require repair. The minor implementation observations were non-defects and are deferred without code changes.

Exact-head build and verify checks are green.

@jscott3201
jscott3201 merged commit 0c938b9 into main Aug 24, 2026
3 checks passed
@jscott3201
jscott3201 deleted the feat/rust-declaration-syntax-checks branch August 25, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant