feat(routines): check typed Rust declaration syntax - #95
Merged
Conversation
jscott3201
commented
Aug 24, 2026
jscott3201
left a comment
Owner
Author
There was a problem hiding this comment.
Cycle 1 consolidated review: PASS at 59e56f95fbaee980ce111938f4b7e9821f4701a3.
Both independent reviewers were blocker/major-clean. No confirmed findings require repair. The minor implementation observations were non-defects and are deferred without code changes.
Exact-head build and verify checks are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
The checker deliberately does not claim inventory or tree membership, inheritance resolution, class kind, declared type resolution, dependency resolution, persisted evidence, or runtime CXF behavior. Rumoca remains an in-process parser without hard time or stack isolation.
Validation
cargo fmt --manifest-path tools/routine-compiler/Cargo.toml -- --checkcargo test --locked --manifest-path tools/routine-compiler/Cargo.toml(89 passed)cargo clippy --locked --manifest-path tools/routine-compiler/Cargo.toml --all-targets -- -D warnings