feat(routines): add capability-rooted declaration source reader - #97
Merged
Conversation
jscott3201
commented
Aug 24, 2026
jscott3201
left a comment
Owner
Author
There was a problem hiding this comment.
Cycle 1 consolidated review: PASS at 92407abb771feaf6484fa6df3144a02f117f3d09.
Both independent reviewers were blocker/major-clean. Deferred minor M1: full-identity deduplication uses bounded linear-vector membership, which can become quadratic at unusually high caller-selected document limits; current G36 scale and explicit limits make this non-blocking, so no code change is warranted in this PR.
Exact-head build and verify checks are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cap-std4.0.2 for confined relative filesystem accessScope
Callers remain responsible for opening and validating checkout roots. The reader does not run Git, inspect pins or inventory, authenticate checkout identity, hash bytes, decode UTF-8, parse Modelica, or inspect declarations. Existing syntax checking remains the sole blob and content authority. No pipeline/CLI integration, production artifacts, schema changes, or external repository work is included.
Validation
cargo fmt --manifest-path tools/routine-compiler/Cargo.toml -- --checkcargo test --locked --manifest-path tools/routine-compiler/Cargo.toml(109 passed)cargo clippy --locked --manifest-path tools/routine-compiler/Cargo.toml --all-targets -- -D warnings