feat(routines): add rooted declaration pipeline - #98
Merged
Conversation
Compose capability-relative source acquisition with the typed declaration pipeline while preserving existing APIs and stage errors. Share preparation logic and apply one limits value across source and syntax checks.
jscott3201
commented
Aug 24, 2026
jscott3201
left a comment
Owner
Author
There was a problem hiding this comment.
Consolidated review — cycle 1: PASS
Reviewed immutable head f53d870acf41a78d4b9b28e4f0d595acac58e6c2 against base ce9750e4abc1fd95019a8dd202cd302f4e2fe9a6.
Both independent review lenses are blocker/major-clean. No findings were confirmed or deferred. The stage order, error preservation, limits mapping, borrowed capability roots, existing in-memory API behavior, and bounded scope are supported by the implementation and focused tests.
Exact-head GitHub build and verify checks succeeded. Local focused, package, clippy, repository lint, inventory, verifier, dataset/replay, book, and diff gates also passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scope
The existing pipeline signature and error variants remain unchanged. This adds no CLI, schema, serialization, provenance validation, production artifacts, dependencies, or external-repository integration.
Validation
cargo fmt --manifest-path tools/routine-compiler/Cargo.toml -- --checkgit diff --check