Repository navigation
Align base64 implementations - #112
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 3 +1
Lines 38 48 +10
Branches 10 14 +4
=========================================
+ Hits 38 48 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
blakeembrey
commented
Nov 3, 2026
|
|
||
| const CREDENTIALS_REGEXP = | ||
| /^ *(?:[Bb][Aa][Ss][Ii][Cc]) +([A-Za-z0-9._~+/-]+=*) *$/; | ||
| const CREDENTIALS_REGEXP = /^ *Basic +([a-z0-9+/]+=*) *$/i; |
Member
Author
There was a problem hiding this comment.
Base64 instead of base68 (which is for other schemes) validation.
Contributor
|
Sorry for the late feedback, but wasn’t this a breaking change? |
Member
Author
You weren't late, I was just eager. While it's breaking in the sense that some things worked before on node that won't now, I don't consider it breaking because it improved RFC compliance and fixed bugs in the non-node implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing the change requested in #110 and goes further to full coverage.
Based on perf testing and differences in the parsers I opted to support well formed base64 only and reject the invalid base64 padding. No padding remains since both decoders already support it.
Switched to using
expect.toEqualfor readability in the outputs too, sorry for that noise.