Skip to content

Commit ddef682

Browse files
committed
- shGithubPrCreate - jslint-regression - Fix long-running regression where 'let x = x;' doesn't warn about temporal-dead-zone.
1 parent bc89d2f commit ddef682

5 files changed

Lines changed: 26 additions & 38 deletions

File tree

.ci.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -456,7 +456,7 @@ import moduleFs from "fs";
456456
"type": "git",
457457
"url": "https://github.com/jslint-org/jslint.git"
458458
},
459-
"version": "2026.6.30"
459+
"version": "2026.7.1"
460460
}, undefined, 4)
461461
}
462462
].map(async function ({

README.md

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1023,16 +1023,7 @@ if (false) {
10231023
sh jslint_ci.sh shGithubPrUpdatePrxxx
10241024

10251025
# re-run until version propagates
1026-
sh jslint_ci.sh shGithubPrCreate alpha beta # v20xx.xx.xx
1027-
1028-
# squash intermediary commits
1029-
sh jslint_ci.sh shGitSquashPop __pr_beta_pre "- ci - shGithubPrUpdatePrxxx."
1030-
1031-
# squash intermediary commits
1032-
sh jslint_ci.sh shGithubPrCreate alpha beta # v20xx.xx.xx
1033-
1034-
# squash intermediary commits
1035-
git push . __pr_beta_pre~:__pr_beta_pre -f
1026+
sh jslint_ci.sh shGithubPrCreate alpha beta # v20yy.mm.dd __pr_beta_pre
10361027

10371028
git push upstream alpha -f
10381029
```
@@ -1090,16 +1081,7 @@ if (false) {
10901081
sh jslint_ci.sh shGithubPrUpdatePrxxx
10911082
10921083
# re-run until version propagates
1093-
sh jslint_ci.sh shGithubPrCreate alpha master # v20xx.xx.xx
1094-
1095-
# squash intermediary commits
1096-
sh jslint_ci.sh shGitSquashPop __pr_master_pre "- ci - shGithubPrUpdatePrxxx."
1097-
1098-
# squash intermediary commits
1099-
sh jslint_ci.sh shGithubPrCreate alpha master # v20xx.xx.xx
1100-
1101-
# squash intermediary commits
1102-
git push . __pr_master_pre~:__pr_master_pre -f
1084+
sh jslint_ci.sh shGithubPrCreate alpha master # v20yy.mm.dd __pr_master_pre
11031085
11041086
git push upstream alpha -f
11051087
```

jslint.mjs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5143,7 +5143,7 @@ function jslint_phase3_parse(state) {
51435143
name.parent.context[id] = name;
51445144
}
51455145

5146-
// PR-xxx - Unify name_list.push() logic with helper-function name_push().
5146+
// PR-502 - Unify name_list.push() logic with helper-function name_push().
51475147

51485148
function name_push(name_list, enroll, name, role, readonly, init) {
51495149

@@ -5898,7 +5898,7 @@ function jslint_phase3_parse(state) {
58985898
// ", "check_ordered", "expected_a_b_before_c_d", "aa", 17]
58995899
// ["let{bb,aa}=0", "check_ordered", "expected_a_b_before_c_d", "aa", 8]
59005900

5901-
// PR-xxx - Fix false-warning about ordering in nested-object-destructuring.
5901+
// PR-501 - Fix false-warning about ordering in nested-object-destructuring.
59025902

59035903
check_ordered(role, sub_list);
59045904
advance_and_signature_push("}");
@@ -8478,7 +8478,7 @@ function jslint_phase4_walk(state) {
84788478
test_cause("let aa");
84798479
}
84808480

8481-
// PR-xxx - Fix long-running regression where 'let x = x;'
8481+
// PR-502 - Fix long-running regression where 'let x = x;'
84828482
// doesn't warn about temporal-dead-zone.
84838483

84848484
// 1a. Mark not dead, the variable, after variable-initialization.
@@ -8737,7 +8737,7 @@ function jslint_phase4_walk(state) {
87378737
warn("unexpected_a", thing);
87388738
}
87398739

8740-
// PR-xxx - Probably deadcode.
8740+
// PR-502 - Probably deadcode.
87418741

87428742
// function pre_b_lparen(thing) {
87438743
//
@@ -9105,7 +9105,7 @@ function jslint_phase4_walk(state) {
91059105
preaction("assignment", pre_a_bitwise);
91069106
preaction("binary", "!=", pre_b_noteq);
91079107

9108-
// PR-xxx - Probably deadcode.
9108+
// PR-502 - Probably deadcode.
91099109

91109110
// preaction("binary", "(", pre_b_lparen);
91119111

@@ -9763,7 +9763,7 @@ function jslint_phase5_whitage(state) {
97639763
// or used. If the file imports or exports, then its global object is also
97649764
// delved.
97659765

9766-
// PR-xxx - tighten warning of unused variables to be always on.
9766+
// PR-502 - tighten warning of unused variables to be always on.
97679767

97689768
delve(token_global);
97699769
catch_list.forEach(delve);

jslint_ci.sh

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1158,12 +1158,16 @@ import moduleAssert from "assert";
11581158
import moduleChildProcess from "child_process";
11591159
import moduleFs from "fs";
11601160
(async function () {
1161-
let branchCheckpoint = process.argv[1] || "HEAD";
1162-
let branchMerge = process.argv[2] || "beta";
1161+
let [
1162+
,
1163+
branchCheckpoint = "HEAD",
1164+
branchMerge = "beta",
1165+
version = new Date().toISOString().slice(0, 10),
1166+
branchSquash = "HEAD"
1167+
] = process.argv;
11631168
let branchPull;
11641169
let commitMessage;
11651170
let data;
1166-
let version = process.argv[3] || new Date().toISOString().slice(0, 10);
11671171
version = version.replace((/-0?/g), ".").replace((/^v/), "");
11681172
// security - sanitize branchXxx
11691173
[
@@ -1193,6 +1197,7 @@ import moduleFs from "fs";
11931197
commitMessage = (
11941198
/\n\n# v\d\d\d\d\.\d\d?\.\d\d?(?:-.*?)?\n(- [\S\s]+?)(?:\n- |\n\n)/
11951199
).exec(data)[1];
1200+
commitMessage = `- shGithubPrCreate ${commitMessage}`;
11961201
}
11971202
branchPull = `branch-${version}`;
11981203
// update README.md
@@ -1211,7 +1216,7 @@ import moduleFs from "fs";
12111216
);
12121217
await moduleFs.promises.writeFile("README.md", data);
12131218
// security - sanitize commitMessage
1214-
commitMessage = commitMessage.trim().replace((/[$\u0027`]/g), "?");
1219+
commitMessage = commitMessage.trim().replace((/\u0027/g), "$&\"$&\"$&");
12151220
moduleChildProcess.spawn(
12161221
"sh",
12171222
[
@@ -1220,13 +1225,14 @@ import moduleFs from "fs";
12201225
(set -e
12211226
. ./jslint_ci.sh
12221227
npm run test2
1223-
git push . HEAD:__pr_${branchMerge}_pre -f
1224-
shGitSquashPop ${branchCheckpoint} \u0027${commitMessage}\u0027
1225-
git diff origin/${branchPull} || true
1226-
git push origin alpha:${branchPull} -f
1228+
git reset "${branchSquash}"
1229+
git push . HEAD:__pr_"${branchMerge}"_pre -f
1230+
shGitSquashPop "${branchCheckpoint}" \u0027${commitMessage}\u0027
1231+
git diff origin/"${branchPull}" || true
1232+
git push origin alpha:"${branchPull}" -f
12271233
git push origin alpha -f
12281234
shDirHttplinkValidate
1229-
git push . HEAD:__pr_${branchMerge} -f
1235+
git push . HEAD:__pr_"${branchMerge}" -f
12301236
git log -n 4
12311237
)
12321238
`)
@@ -1235,7 +1241,7 @@ import moduleFs from "fs";
12351241
).on("exit", function (exitCode) {
12361242
moduleAssert.ok(
12371243
exitCode === 0,
1238-
`shGithubPrCreate - exitCode=${exitCode}`
1244+
`shGithubPrCreate - exitCode="${exitCode}"`
12391245
);
12401246
});
12411247
}());

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,5 @@
3535
"shCiArtifactUpload": 1,
3636
"shCiPublishNpm": 1,
3737
"type": "module",
38-
"version": "2026.6.30"
38+
"version": "2026.7.1-beta"
3939
}

0 commit comments

Comments
 (0)