feat: populate <skipped> message with last line of test output - #158
Open
marcuscaisey wants to merge 3 commits into
Open
feat: populate <skipped> message with last line of test output#158marcuscaisey wants to merge 3 commits into
marcuscaisey wants to merge 3 commits into
Conversation
This was referenced Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets the
<skipped>node's message attribute to the last line of the output from the skipped test.I've made this change as I came across an issue when trying to integrate this tool with https://github.com/thought-machine/please which only looks at the message attribute of the
<skipped>node and not the containing text, so was outputtingSkippedas the reason for each skipped test which isn't very helpful.This seems more the correct behaviour imo since this is how JUnit outputs its XML report:
I've left the remaining lines of test output in the text of the
<skipped>node. I'm not sure whether it should just contain all of the output lines (or none). I just did it this way to not duplicate info between the message and node text. I don't expect this case to really come up tbh since logging before skipping a test seems a bit odd.