fix: lowercase DNS extra record names - #3366
Open
larrasket wants to merge 2 commits into
Open
Conversation
larrasket
requested review from
juanfont,
kradalby,
nblock and
ohdearaugustin
as code owners
July 4, 2026 13:16
larrasket
force-pushed
the
extra-records-case-insensitive
branch
from
July 4, 2026 13:29
722f652 to
e63dcfd
Compare
DNS names are case-insensitive, but clients match extra records against the lowercased query name, so records with mixed-case names (for example "Printer.fritz.box" in an extra_records_path file) never resolved and queries fell through to the global nameserver. Normalize record names to lowercase where the records enter the tailcfg DNS config, covering both dns.extra_records and extra_records_path. Fixes juanfont#2782
larrasket
force-pushed
the
extra-records-case-insensitive
branch
from
August 27, 2026 05:43
e63dcfd to
b690ee1
Compare
kradalby
reviewed
Sep 1, 2026
| - Improve systemd service file hardening [#3341](https://github.com/juanfont/headscale/pull/3341) | ||
| - Headscale now requires Go 1.27 to build | ||
| - Lowercase DNS extra record names so mixed-case records resolve [#2782](https://github.com/juanfont/headscale/issues/2782) | ||
|
|
Collaborator
There was a problem hiding this comment.
Lets link the PR here in the changelog to follow the same style. Can you move it to under 0.29.4 and we get it out quicker.
kradalby
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DNS names are case-insensitive, but clients match extra records against the lowercased query name, so records with mixed-case names (for example "Printer.fritz.box" in an extra_records_path file) never resolved and queries fell through to the global nameserver.
Normalize record names to lowercase where the records enter the tailcfg DNS config, covering both dns.extra_records and extra_records_path.
Fixes #2782