Split ReproduceCommand.run() into a helper; gate unused imports with swiftlint analyze

ReproduceCommand.run() split into ReproduceCommand+Execution.swift, no
behavior change. Adds a swiftlint analyze CI job (unused_import only)
gated into the merge gate, after removing the 74 unused imports it
found across the tree.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: juntaki

.github/workflows/ci.yml

@@ -163,6 +163,45 @@ jobs:
         shell: bash
         run: swift-complexity Sources Tests --recursive --threshold 25 --report-suppressions
 
+  # Compiler-aware lint: `unused_import` only (see .swiftlint.yml's own
+  # `analyzer_rules` comment). Needs a clean xcodebuild log, so it pays for
+  # a full `MutantKit-Package` build where `lint` needs none — a separate
+  # job rather than a step there, so the fast static checks and this gate
+  # never block each other. The pre-existing set (74 true positives on this
+  # tree, not the 66 a syntax-only per-file scan over a *different* file set
+  # would suggest -- private targets excluded from the public snapshot
+  # change the count) was removed outright before this gate was switched on,
+  # so any finding here is new debt.
+  analyze:
+    name: Unused imports (swiftlint analyze)
+    runs-on: macos-15
+    timeout-minutes: 20
+    env:
+      SWIFTLINT_VERSION: "0.63.2"
+    steps:
+      - uses: actions/checkout@v4
+      - name: Install pinned SwiftLint
+        run: |
+          curl -fsSL -o portable_swiftlint.zip \
+            "https://github.com/realm/SwiftLint/releases/download/${SWIFTLINT_VERSION}/portable_swiftlint.zip"
+          unzip -o portable_swiftlint.zip swiftlint
+          chmod +x swiftlint
+          sudo mv swiftlint /usr/local/bin/swiftlint
+          rm portable_swiftlint.zip
+          installed_version="$(swiftlint version)"
+          if [ "$installed_version" != "$SWIFTLINT_VERSION" ]; then
+            echo "::error::Installed SwiftLint $installed_version does not match pinned SWIFTLINT_VERSION $SWIFTLINT_VERSION"
+            exit 1
+          fi
+      - name: Clean build for analyzer
+        shell: bash
+        run: |
+          set -o pipefail
+          xcodebuild -scheme MutantKit-Package -destination 'generic/platform=macOS' clean build 2>&1 | tee xcodebuild.log
+      - name: swiftlint analyze
+        shell: bash
+        run: swiftlint analyze --strict --config .swiftlint.yml --compiler-log-path xcodebuild.log Sources
+
   # Fast feedback: everything that does not build another project.
   unit:
     name: Unit tests
@@ -740,6 +779,7 @@ jobs:
     needs:
       - lint
       - complexity
+      - analyze
       - unit
       - acceptance
       - ror-schemata-differential
@@ -763,6 +803,7 @@ jobs:
 
           check "lint" "${{ needs.lint.result }}"
           check "complexity" "${{ needs.complexity.result }}"
+          check "analyze" "${{ needs.analyze.result }}"
           check "unit" "${{ needs.unit.result }}"
           check "acceptance" "${{ needs.acceptance.result }}"
           check "ror-schemata-differential" "${{ needs.ror-schemata-differential.result }}"

.swiftlint-baseline.json

@@ -6,7 +6,7 @@
       "ruleName": "Type Body Length",
       "location": {
         "file": "Sources/AppleBuildAdapters/SimulatorPool.swift",
-        "line": 152,
+        "line": 150,
         "character": 8
       },
       "reason": "Actor body should span 300 lines or less excluding comments and whitespace: currently spans 341 lines",
@@ -21,11 +21,11 @@
       "ruleName": "Function Body Length",
       "location": {
         "file": "Sources/AppleBuildAdapters/XcodeBuildAdapter.swift",
-        "line": 1560,
+        "line": 1606,
         "character": 12
       },
       "reason": "Function body should span 80 lines or less excluding comments and whitespace: currently spans 87 lines",
-      "severity": "error"
+      "severity": "warning"
     },
     "text": "    public func runBatch("
   },
@@ -81,44 +81,14 @@
       "ruleName": "Unused Enumerated",
       "location": {
         "file": "Sources/BudgetV2Eval/Statistics.swift",
-        "line": 30,
+        "line": 34,
         "character": 29
       },
       "reason": "When the index is not used, `.enumerated()` can be removed",
       "severity": "error"
     },
     "text": "        let sorted = pooled.enumerated().sorted { $0.element.value < $1.element.value }"
   },
-  {
-    "violation": {
-      "ruleIdentifier": "cyclomatic_complexity",
-      "ruleDescription": "Complexity of function bodies should be limited.",
-      "ruleName": "Cyclomatic Complexity",
-      "location": {
-        "file": "Sources/CLI/Commands/ReproduceCommand.swift",
-        "line": 38,
-        "character": 5
-      },
-      "reason": "Function should have complexity 12 or less; currently complexity is 13",
-      "severity": "error"
-    },
-    "text": "    func run() async throws {"
-  },
-  {
-    "violation": {
-      "ruleIdentifier": "function_body_length",
-      "ruleDescription": "Function bodies should not span too many lines",
-      "ruleName": "Function Body Length",
-      "location": {
-        "file": "Sources/CLI/Commands/ReproduceCommand.swift",
-        "line": 38,
-        "character": 5
-      },
-      "reason": "Function body should span 80 lines or less excluding comments and whitespace: currently spans 135 lines",
-      "severity": "error"
-    },
-    "text": "    func run() async throws {"
-  },
   {
     "violation": {
       "ruleIdentifier": "type_body_length",
@@ -621,7 +591,7 @@
       "ruleName": "Line Length",
       "location": {
         "file": "Sources/MutationModel/VerdictProof.swift",
-        "line": 31,
+        "line": 29,
         "character": 1
       },
       "reason": "Line should be 140 characters or less; currently it has 157 characters",
@@ -2038,35 +2008,5 @@
       "severity": "error"
     },
     "text": "struct XCResultAdapterBatchTests {"
-  },
-  {
-    "violation": {
-      "ruleIdentifier": "line_length",
-      "ruleDescription": "Lines should not span too many characters.",
-      "ruleName": "Line Length",
-      "location": {
-        "file": "Tests/MutantKitTests/Unit/XcodeBuildAdapterUninstallFailureTests.swift",
-        "line": 66,
-        "character": 1
-      },
-      "reason": "Line should be 140 characters or less; currently it has 159 characters",
-      "severity": "error"
-    },
-    "text": "        SimulatorLease(device: SimulatorDevice(udid: udid, name: \"Bogus\", runtimeIdentifier: \"com.apple.CoreSimulator.SimRuntime.iOS-18-0\", state: \"Shutdown\"))"
-  },
-  {
-    "violation": {
-      "ruleIdentifier": "line_length",
-      "ruleDescription": "Lines should not span too many characters.",
-      "ruleName": "Line Length",
-      "location": {
-        "file": "Tests/MutantKitTests/Unit/XcodeBuildAdapterUninstallFailureTests.swift",
-        "line": 73,
-        "character": 1
-      },
-      "reason": "Line should be 140 characters or less; currently it has 148 characters",
-      "severity": "error"
-    },
-    "text": "        let message = XcodeBuildAdapter.uninstallFailureWarning(bundleID: \"com.example.App\", udid: \"ABCD-1234\", detail: \"Invalid device: ABCD-1234\")"
   }
 ]

.swiftlint.yml

@@ -9,26 +9,26 @@
 # to stop erroring, left as a warning, documented here).
 #
 # CI runs `swiftlint lint --strict --baseline .swiftlint-baseline.json`:
-# the baseline freezes 138 pre-existing violations by identity (rule + file +
+# the baseline freezes 134 pre-existing violations by identity (rule + file +
 # line) so `--strict` still catches every new violation, including a new one
 # in an already-baselined file, without forcing a refactor of any of them
-# just to silence the linter. By rule: `line_length` 80 (mostly long test
+# just to silence the linter. By rule: `line_length` 78 (mostly long test
 # lines and interpolated diagnostics), `type_body_length` 16, `large_tuple`
-# 13, `function_body_length` 10, `function_parameter_count` 6,
-# `cyclomatic_complexity` 4, `file_length` 5, `force_try` 2, plus one
+# 13, `function_body_length` 9, `function_parameter_count` 6,
+# `file_length` 5, `cyclomatic_complexity` 3, `force_try` 2, plus one
 # `unused_enumerated` and one `orphaned_doc_comment`. The length/complexity
 # rules concentrate in a few deliberately large orchestration files
 # (MutationRunner.swift, SchemataMutationRunner.swift, XcodeBuildAdapter.swift
-# and similar), but `cyclomatic_complexity` also covers a ReproduceCommand
-# handler (13), ConfigurationValidation (13), DeclarationIdentityResolver
-# (15) and one simulator-pool test — and `large_tuple` is spread across
-# several test files. This count includes a handful of entries private-tree-
-# only targets (research/probe executables, benchmark harness) contribute
-# that the public projection's own baseline doesn't carry, since those
-# targets are excluded from the public snapshot. (Earlier versions of this
-# comment also named InspectCommand.run()/RunCommand.run(), and then
-# QualityGate.evaluate (16)/BudgetSelectorV2.allocateCounts (18); all four
-# have since been split far enough that none is baselined anymore.)
+# and similar), but `cyclomatic_complexity` also covers ConfigurationValidation
+# (13), DeclarationIdentityResolver (15) and one simulator-pool test — and
+# `large_tuple` is spread across several test files. This count includes a
+# handful of entries private-tree-only targets (research/probe executables,
+# benchmark harness) contribute that the public projection's own baseline
+# doesn't carry, since those targets are excluded from the public snapshot.
+# (Earlier versions of this comment also named InspectCommand.run()/
+# RunCommand.run(), then QualityGate.evaluate (16)/
+# BudgetSelectorV2.allocateCounts (18), then a ReproduceCommand handler (13);
+# all five have since been split far enough that none is baselined anymore.)
 #
 # Baseline entries key on line number, so an unrelated edit earlier in a
 # baselined file shifts every violation below it and makes CI fail on an
@@ -137,3 +137,10 @@ disabled_rules:
   # oversight — forcing the failable initializer here would just add an
   # unwrap for a case that can't happen.
   - optional_data_string_conversion
+
+# Compiler-aware rules: these run ONLY under `swiftlint analyze` with a
+# clean xcodebuild log, never under `swiftlint lint`. Scope is deliberately
+# one rule: `unused_import` catches exactly the failure class a pure file
+# move introduces (a leftover import no syntax-only rule sees).
+analyzer_rules:
+  - unused_import

Sources/AppleBuildAdapters/DestinationResolver.swift

@@ -1,5 +1,4 @@
 import Foundation
-import MutationModel
 
 /// One `-destination` specifier, resolved to a concrete device (or proven to
 /// need none), once, at run start.

Sources/AppleBuildAdapters/SchemataBuiltImageInspection.swift

@@ -1,5 +1,4 @@
 import Foundation
-import MutationExecution
 import MutationModel
 
 /// Every way `SchemataBuiltImageInspection.inspect` refuses to produce a

Sources/AppleBuildAdapters/SchemataRuntimeManifest.swift

@@ -1,5 +1,3 @@
-import Foundation
-
 /// The shape of `lib/mutantkit/schemata/manifest.json` — the file a
 /// released `mutantkit` tarball bundles alongside its per-platform
 /// `MutantKitSchemataRuntime` archives (`scripts/release-build.sh` produces

Sources/AppleBuildAdapters/SimulatorPool.swift

@@ -1,7 +1,5 @@
-import Darwin
 import Foundation
 import MutationExecution
-import MutationModel
 
 /// One simulator, as `simctl` describes it.
 public struct SimulatorDevice: Codable, Sendable, Hashable {

Sources/AppleBuildAdapters/SwiftPMCompilationUnitImageResolver.swift

@@ -1,7 +1,3 @@
-import Foundation
-import MutationExecution
-import MutationModel
-
 /// Every way the SwiftPM path refuses to map a compilation unit's target to
 /// a real built image — fail-closed: an ambiguous or unproven mapping must
 /// never be resolved by guessing.

Sources/AppleBuildAdapters/XcodeConfigDetector.swift

@@ -1,5 +1,4 @@
 import Foundation
-import MutationExecution
 import MutationModel
 
 /// Real auto-detection of an Xcode project/workspace's scheme, test

Sources/CLI/Commands/ConfigCommand.swift

@@ -1,5 +1,4 @@
 import ArgumentParser
-import Foundation
 import MutationModel
 
 /// Validates `mutantkit.yml` or emits the JSON Schema used by editors/CI.