Bundle static js files and node_modules in the python package - #89
Draft
Darshan808 wants to merge 3 commits into
Draft
Bundle static js files and node_modules in the python package#89Darshan808 wants to merge 3 commits into
js files and node_modules in the python package#89Darshan808 wants to merge 3 commits into
Conversation
Member
Author
|
Not sure if we want to move forward with this approach, but it’s one option that works reliably. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #81
Description
Added scripts to bundle the
lib/directory together withnode_modules/into the Python package.While this works, the packaged
node_modulesincludes platform-specific binaries (binding-darwin-arm64/rspack.darwin-arm64.nodeon my macOS).This means platform-specific wheels per architecture will be required.