Skip to content

fix: check for bundled paths - #383

Merged
balaganesh-juspay merged 1 commit into
mainfrom
fix-get-asset-path
Aug 13, 2026
Merged

balaganesh-juspay merged 1 commit into
mainfrom
fix-get-asset-path

Conversation

@Yash02Rajput

@Yash02Rajput Yash02Rajput commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Improved asset file lookup for release configurations.
    • Correctly falls back to bundled assets when downloaded resources are unavailable.
    • Prevents invalid file paths from being returned when no matching asset exists.

@semanticdiff-com

semanticdiff-com Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review changes with  SemanticDiff

Changed Files
File Status
  airborne_server/src/build.rs  53% smaller
  airborne_sdk_iOS/hyper-ota/Airborne/AirborneSwift/AJPApplicationManager.swift  22% smaller

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cc01083f-23f4-4e68-a0b6-0687d86a50fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

getPathForAssetsInReleaseConfig now validates downloaded package files and falls back to an existing bundled asset when the downloaded file is unavailable.

Changes

Asset path lookup

Layer / File(s) Summary
Validated asset resolution
airborne_sdk_iOS/hyper-ota/Airborne/AirborneSwift/AJPApplicationManager.swift
The method verifies that the downloaded package exists before returning its path. If it does not exist, the method checks a bundled asset path and returns nil only when both paths are unavailable.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: yuvrajjsingh0

Poem

A rabbit checks each asset trail,
Confirms the file before the sail.
If downloads hide, the bundle shines,
A fallback waits through path designs.
No file? Then nil closes the gate.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: checking bundled paths when resolving asset files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-get-asset-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@balaganesh-juspay
balaganesh-juspay merged commit 369fcb3 into main Aug 13, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants