Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I opened PR #1 with support for the SikaiCase 1189:8842 12-key / 4-encoder variant.
I wanted to mention that the protocol details in the PR were determined and tested against my physical device, rather than inferred from the existing layouts.
The two important device-specific findings are:
encoder 4 uses slots 0x0D–0x0F, while encoders 1–3 use 0x10–0x18;
reading the 24 records requires FA 0F 03 rather than the generic FA 0C 04 .
I also physically tested reading, writing, committing, reconnecting and reading the bindings back again.
Hopefully this is useful for supporting this variant. Thanks for creating the project!
What
Adds verified support for the SikaiCase 1189:8842 macropad with 12 keys and 4 rotary encoders.
Hardware verified
1189:88420xFF00, Usage0x010x03Important device-specific details
This model does not use the standard knob slot numbering assumed by the generic layout.
Physical encoder slots are:
| Encoder | CCW | Press | CW |
| K1 |
0x10|0x11|0x12|| K2 |
0x13|0x14|0x15|| K3 |
0x16|0x17|0x18|| K4 |
0x0D|0x0E|0x0F|The fourth encoder is therefore stored before the first three encoder groups.
The device also requires the following read command for its 24 records:
FA 0F 03 <layer>rather than the generic:
FA 0C 04 <layer>Verification
The implementation was tested against a physical SikaiCase 1189:8842 device.
Verified:
The unusual slot mapping and read command were determined from the actual device and verified with physical hardware.
No changes are made to the behavior of the existing layouts.