docs: add design for priority-based in-quota reclaim - #2092
Open
davidLif wants to merge 11 commits into
Open
Conversation
davidLif
force-pushed
the
DavidL/highPriorityReclaimsLowInQuota
branch
3 times, most recently
from
August 26, 2026 14:23
e998c6b to
764dfc8
Compare
Signed-off-by: davidLif <davidshani12@gmail.com>
… docs Signed-off-by: davidLif <davidshani12@gmail.com>
Signed-off-by: davidLif <davidshani12@gmail.com>
Signed-off-by: davidLif <davidshani12@gmail.com>
Signed-off-by: davidLif <davidshani12@gmail.com>
Signed-off-by: davidLif <davidshani12@gmail.com>
Signed-off-by: davidLif <davidshani12@gmail.com>
Signed-off-by: davidLif <davidshani12@gmail.com>
Signed-off-by: davidLif <davidshani12@gmail.com>
davidLif
force-pushed
the
DavidL/highPriorityReclaimsLowInQuota
branch
from
August 30, 2026 19:37
1b4c488 to
b8d31f3
Compare
itsomri
reviewed
Aug 31, 2026
|
|
||
| ## 3. Reclaim Rules | ||
|
|
||
| A candidate victim task is reclaimable via the new path when, for the (leveled) reclaimer queue and victim queue pair: |
Collaborator
Author
There was a problem hiding this comment.
I meant as per the normalization of priority level of non-siblings queues. Will remove.
itsomri
reviewed
Aug 31, 2026
|
|
||
| ``` | ||
|
|
||
| ## 4. No Reclaim Loops |
Collaborator
Author
There was a problem hiding this comment.
I m not sure why adding "why no cascading reclaims" will help this design doc.
In short, the explanation is:
Everything is in quota so the other stratgies are not interesting, and if B can reclaim from reclaimer A under the new strategy, B could have used the same victims as A under the new strategy and A wouldn't have reached the specific reclaim simulation
itsomri
reviewed
Aug 31, 2026
|
|
||
| No code change. Consolidation (`pkg/scheduler/actions/consolidation/`) doesn't call into the `proportion` reclaim strategies at all — its victim filter only checks `IsPreemptibleJob()` and active-task count, because its scenario validator (`allPodsReallocated`) requires every evicted victim to be reallocated somewhere; it repacks, it doesn't permanently transfer resources across queues. The quota-protection concern this feature relaxes doesn't apply to consolidation the same way, so today's behavior already covers "applicable to consolidation" without change. | ||
|
|
||
| ## 7. Edge Cases & Risks |
Collaborator
There was a problem hiding this comment.
Feels like a change in such a sensitive area might have more risks
Collaborator
Author
There was a problem hiding this comment.
This is actually not that big of a change - the only thing we drop is the quota guarantee, and this is mentioned several times in the docs.
itsomri
reviewed
Aug 31, 2026
Signed-off-by: davidLif <davidshani12@gmail.com>
davidLif
enabled auto-merge
September 1, 2026 16:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[](docs: add design for priority-based in-quota reclaim)
Related Issues
Fixes #2065
Checklist
make changelog(or applied theskip-changeloglabel). Do not editCHANGELOG.mddirectly — pending fragments are folded into it at release time.Breaking Changes
Additional Notes