Skip to content

fix(tui): hash installer passwords - #4421

Merged
Itxaka merged 1 commit into
kairos-io:masterfrom
ci-forks:fix/hash-installer-password
Sep 1, 2026
Merged

fix(tui): hash installer passwords#4421
Itxaka merged 1 commit into
kairos-io:masterfrom
ci-forks:fix/hash-installer-password

Conversation

@ci-robbot

Copy link
Copy Markdown
Collaborator

What changed

  • Hash interactive-installer passwords with a random SHA-512 crypt salt before storing them.
  • Clear the password input after successful submission and keep model updates atomic on errors.
  • Keep usable password hashes out of debug bundles.

Verification

  • go test -count=1 ./installer/...

Closes #4413

Generate a salted SHA-512 crypt hash before saving user settings. Cleartext passwords remain only in the password input and are cleared after a successful save.

Signed-off-by: ci-robbot <ci-robbot@users.noreply.github.com>
Assisted-by: Codex
@ci-robbot
ci-robbot requested a review from a team as a code owner August 31, 2026 12:53
@ci-robbot
ci-robbot deployed to fork-pr-builds August 31, 2026 12:53 — with GitHub Actions Active
@ci-robbot

Copy link
Copy Markdown
Collaborator Author

The five red checks do not currently identify a safe code fix. iso-size-diff failed because actions/checkout refused to check out fork code from a pull_request_target workflow. The other four failures are unrelated integration jobs, but GitHub is returning 403 Forbidden for their completed-job log downloads, so I cannot classify them reliably. I also tried to rerun the failed jobs, but this bot account does not have the required repository admin permission. A maintainer rerun is the safest next step.

@Itxaka

Itxaka commented Sep 1, 2026

Copy link
Copy Markdown
Member

really nice, lets make sure we include this in the release notes

@Itxaka

Itxaka commented Sep 1, 2026

Copy link
Copy Markdown
Member

only the iso size diff fails becuase its a fork, rest pases green so lets merge this

@Itxaka
Itxaka merged commit 3d1ace5 into kairos-io:master Sep 1, 2026
129 of 135 checks passed
@github-project-automation github-project-automation Bot moved this from QA to Done ✅ in 🧙Issue tracking board Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done ✅

Development

Successfully merging this pull request may close these issues.

installer should embed encrypted passphrase for users

3 participants