Skip to content

refactor: remove collector mode - #174

Merged
kalil0321 merged 2 commits into
mainfrom
kalil0321/remove-collector
Nov 15, 2026
Merged

kalil0321 merged 2 commits into
mainfrom
kalil0321/remove-collector

Conversation

@kalil0321

@kalil0321 kalil0321 commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Why. Collector mode is a separate web-research agent (web search and fetch, JSON/CSV output) that uses none of rae's capture → API → client pipeline. There is no sign of use: no issue, question or bug report from a user since it shipped in January. Every session change still has to carry it.

What.

  • Removes the collector command, the session's collector mode (mode list, Shift+Tab, its own /model, its UI and colour), collector_model, its prompts, get_collected_dir, and the collector install extra, whose three dependencies were not imported anywhere.
  • Docs: drops the collector page and its mentions (commands, models, quick start, docs home) and the README's. CHANGELOG entry under Unreleased.
  • Old data keeps working. A collector_model in config.json is ignored. Past collector runs still list, show and open in /history, and engineer mode still skips them when it picks the latest capture. ./collected/ folders are untouched. No removal notice: collector is an unknown command like any other.

Verification. pytest: 1300 passed, with a test that /model saves claude_code_model and that agent, manual and engineer runs get the chosen model (it fails when the session drops the model). ruff and mypy clean. Live in the session: haiku 5.5 picked with /model ran a real agent run, then an engineer prompt re-engineered that run on the same model. /settings lists no collector entry, and changing a setting rewrites an old config without collector_model. The built wheel has no collector files and no collector extra; installing with [collector] only warns. Website lint and build pass; the mode pages are agent, engineer and manual. With a HOME holding an old collector_model and a collector run: --help lists no collector, collector exits 2 as an unknown command, list --json and show --json return the run, and in the session /mode and Shift+Tab cycle agent → manual → engineer, /history lists and opens the old run, and /help lists three modes.

Out of scope. The .gitignore entries for collected/ and collector_mode_plan.md, kept while local checkouts still hold those files. No release: this ships with 0.16.0.


Summary by cubic

Removes collector mode, the separate web-research agent that ran outside the normal capture → API → client pipeline and has had no reported use since it shipped in January. The mode, command, config key, prompts, UI, and its install extra are gone, along with their docs.

  • Deletes the collector command, the session mode (Shift+Tab cycle, /model, UI, color), collector_model, get_collected_dir, and the three unused collector-only dependencies.
  • Updates the README, CHANGELOG, and website docs to drop collector mentions.

Old data keeps working: a collector_model in config.json is ignored, past collector runs still show in /history (and engineer mode still skips them when picking the latest capture), and ./collected/ folders are untouched. collector is now an unknown command, so no removal notice is needed.

Written for commit caca644. Summary will update on new commits.

View guided diff Turn on auto-fix

RetriggerView in GreptileConfidence Score: 5/5

The reviewed changes appear safe to merge.

Summary

Removes collector mode, its command, settings, prompts, optional dependencies, and docs.

  • The collector command no longer gathers web data into files.
  • Sessions now offer three modes and one shared Claude model.

Reviews (5) · Last reviewed commit: "test(session): the chosen model is saved..." · Reviewed by Greptile

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T18:29:26.109422Z 071483d New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kalil0321
kalil0321 merged commit 606e889 into main Nov 15, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant