Repository navigation
refactor: remove collector mode - #174
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why. Collector mode is a separate web-research agent (web search and fetch, JSON/CSV output) that uses none of rae's capture → API → client pipeline. There is no sign of use: no issue, question or bug report from a user since it shipped in January. Every session change still has to carry it.
What.
collectorcommand, the session's collector mode (mode list, Shift+Tab, its own/model, its UI and colour),collector_model, its prompts,get_collected_dir, and thecollectorinstall extra, whose three dependencies were not imported anywhere.collector_modelinconfig.jsonis ignored. Past collector runs still list, show and open in/history, and engineer mode still skips them when it picks the latest capture../collected/folders are untouched. No removal notice:collectoris an unknown command like any other.Verification. pytest: 1300 passed, with a test that
/modelsavesclaude_code_modeland that agent, manual and engineer runs get the chosen model (it fails when the session drops the model). ruff and mypy clean. Live in the session: haiku 5.5 picked with/modelran a real agent run, then an engineer prompt re-engineered that run on the same model./settingslists no collector entry, and changing a setting rewrites an old config withoutcollector_model. The built wheel has no collector files and nocollectorextra; installing with[collector]only warns. Website lint and build pass; the mode pages are agent, engineer and manual. With a HOME holding an oldcollector_modeland a collector run:--helplists no collector,collectorexits 2 as an unknown command,list --jsonandshow --jsonreturn the run, and in the session/modeand Shift+Tab cycle agent → manual → engineer,/historylists and opens the old run, and/helplists three modes.Out of scope. The
.gitignoreentries forcollected/andcollector_mode_plan.md, kept while local checkouts still hold those files. No release: this ships with 0.16.0.Summary by cubic
Removes collector mode, the separate web-research agent that ran outside the normal capture → API → client pipeline and has had no reported use since it shipped in January. The mode, command, config key, prompts, UI, and its install extra are gone, along with their docs.
collectorcommand, the session mode (Shift+Tab cycle,/model, UI, color),collector_model,get_collected_dir, and the three unused collector-only dependencies.Old data keeps working: a
collector_modelinconfig.jsonis ignored, past collector runs still show in/history(and engineer mode still skips them when picking the latest capture), and./collected/folders are untouched.collectoris now an unknown command, so no removal notice is needed.Written for commit caca644. Summary will update on new commits.


Confidence Score: 5/5
The reviewed changes appear safe to merge.Summary
Removes collector mode, its command, settings, prompts, optional dependencies, and docs.
collectorcommand no longer gathers web data into files.Reviews (5) · Last reviewed commit: "test(session): the chosen model is saved..." · Reviewed by Greptile