Repository navigation
build: keep the whole .claude/ folder out of the sdist - #177
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why. The sdist excluded only three paths under
.claude/(settings.local.json,worktrees/**,plans/**). A build from a checkout with other local tooling, such as the e2e harness in.claude/e2e/, ships it in the tarball. The published 0.15.0 sdist has none (checked), but the next build from a working checkout could.What. One
.claude/**exclusion replaces the three paths.Verification.
uv build --sdistfrom a checkout that has.claude/e2e/: 0 files under.claude/in the tarball (147 files: src, tests, scripts, project docs). The wheel is unchanged: it only packagessrc/reverse_api.Out of scope. No release.
Summary by cubic
Keeps the entire
.claude/folder out of the sdist so local tooling like the e2e harness, settings, worktrees, and plans never end up in the tarball..claude/exclusions with a single.claude/**pattern.src/reverse_api.Written for commit 7982ce0. Summary will update on new commits.


Confidence Score: 5/5
This PR appears safe to merge.Summary
Broadens the source archive exclusion in
pyproject.tomlto cover all files under.claude/..claude/.Reviews (1) · Last reviewed commit: "build: keep the whole .claude/ folder ou..." · Reviewed by Greptile