Skip to content

build: keep the whole .claude/ folder out of the sdist - #177

Merged
kalil0321 merged 1 commit into
mainfrom
kalil0321/sdist-exclude-claude
Nov 15, 2026
Merged

kalil0321 merged 1 commit into
mainfrom
kalil0321/sdist-exclude-claude

Conversation

@kalil0321

@kalil0321 kalil0321 commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Why. The sdist excluded only three paths under .claude/ (settings.local.json, worktrees/**, plans/**). A build from a checkout with other local tooling, such as the e2e harness in .claude/e2e/, ships it in the tarball. The published 0.15.0 sdist has none (checked), but the next build from a working checkout could.

What. One .claude/** exclusion replaces the three paths.

Verification. uv build --sdist from a checkout that has .claude/e2e/: 0 files under .claude/ in the tarball (147 files: src, tests, scripts, project docs). The wheel is unchanged: it only packages src/reverse_api.

Out of scope. No release.


Summary by cubic

Keeps the entire .claude/ folder out of the sdist so local tooling like the e2e harness, settings, worktrees, and plans never end up in the tarball.

  • Replaces the three specific .claude/ exclusions with a single .claude/** pattern.
  • The wheel is unaffected; it still only packages src/reverse_api.

Written for commit 7982ce0. Summary will update on new commits.

View guided diff Turn on auto-fix

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge.

Summary

Broadens the source archive exclusion in pyproject.toml to cover all files under .claude/.

  • Source archives leave out every file under .claude/.

Reviews (1) · Last reviewed commit: "build: keep the whole .claude/ folder ou..." · Reviewed by Greptile

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T20:11:43.636340Z 7982ce0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kalil0321
kalil0321 merged commit ad6fa97 into main Nov 15, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant