Skip to content

fix: remove the player view when destroy player - #471

Open
passerbyloo wants to merge 1 commit into
kaltura:developfrom
passerbyloo:fix-destroy-function
Open

fix: remove the player view when destroy player#471
passerbyloo wants to merge 1 commit into
kaltura:developfrom
passerbyloo:fix-destroy-function

Conversation

@passerbyloo

Copy link
Copy Markdown

Description of the Changes

when call player.destroy().
the player view still not remove/release, like

player.destroy()
player = PlayKitManager.sharedInstance.loadPlayer(config: config)
playerView = PlayerView.createPlayerViewForPlayer(player)

if play the same video source in two player, the video can not play normally.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant