Add missing Arabic translations (FEC-14996) - #1197
Open
bw-kaltura wants to merge 1 commit into
Open
Conversation
Adds customer-supplied Arabic strings for secondsRewind/secondsForward and all other previously-untranslated keys in translations/ar.i18n.json. https://kaltura.atlassian.net/browse/FEC-14996
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Arabic locale file to fill in previously missing i18n strings so the player UI (controls, volume accessibility labels, error states, CVAA presets, and audio description UI) can be fully localized in ar.
Changes:
- Adds missing
controls,volume, andsettingskeys (includingsecondsRewind/secondsForwardplaceholders). - Adds missing
errormessages/titles and additional CVAA-related labels. - Adds missing sections for
watermark,spinner,videoArea,audioDescription, andmediaInfo.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "media_unavailable_error_message": "تم تقييد هذه الوسائط. يُرجى الحصول على الأذونات المطلوبة للوصول إلى المحتوى", | ||
| "text_error_title": "خطأ في تدفق النص", | ||
| "text_error_message": "حدث خطأ في تدفق النص", | ||
| "media_error_title": "خطأ في تدفق النص", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
translations/ar.i18n.json, includingsecondsRewind/secondsForwardwhich were explicitly called out as missing in the ticket.Notes for reviewer
error.media_error_titleanderror.text_error_titlewere supplied with identical Arabic text, even though the English source strings are distinct ("Media stream error" vs. "Text stream error"). This looks like a translator copy/paste slip in the source document. Kept as-supplied for this PR — flagging so we can confirm with the customer/translator before merge, or fix if we'd rather not wait.secondsRewind/secondsForwardhad{{--}}instead of{{seconds}}) — these were corrected back to matchen.i18n.jsonplaceholder names while keeping the customer's Arabic wording.transcript-style pairsattach_transcript/attach_transcript_button(n/a here, see companion PR) aren't in this repo; for playkit-js-ui itself no other duplicate-text issues were found beyond the one above.Test plan
python3 -m json.toolpasses locally)arlocale and visually confirm rewind/forward tooltips showsecondsRewind/secondsForwardcorrectlymedia_error_titlevstext_error_titlewording intentRef: https://kaltura.atlassian.net/browse/FEC-14996
🤖 Generated with Claude Code