fix(FEC-15083): Add right controls to xs player - #1198
Merged
valentinStoicaK merged 1 commit intoAug 25, 2026
Conversation
valentinStoicaK
requested review from
ravitshalem and
roeedean
and
a lite review from Copilot
August 25, 2026 10:42
Contributor
There was a problem hiding this comment.
Pull request overview
Enables right-side bottom-bar controls for extra-small players and updates overflow handling.
Changes:
- Removes the XS rule hiding right controls.
- Adjusts overflow-based control filtering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Summary | Review result |
|---|---|---|
src/components/bottom-bar/bottom-bar-utils.ts |
Updates overflow filtering. | Moderate issue: the 20% buffer can remove two controls when one is sufficient, causing an extra right control to disappear. |
src/components/bottom-bar/_bottom-bar.scss |
Allows right controls for XS players. | No issues identified. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ravitshalem
reviewed
Aug 25, 2026
roeedean
approved these changes
Aug 25, 2026
ravitshalem
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://kaltura.atlassian.net/browse/FEC-15083