Revert "fix(FEC-15083): Add right controls to xs player"

[valentinStoicaK]

Reverts #1198

[Copilot]

Pull request overview

Reverts prior changes from #1198, restoring the previous XS-player bottom bar behavior and the prior overflow-controls calculation.

Changes:

• Remove the extra overflow “buffer” in filterControlsByPriority so overflow controls are computed strictly by width delta.
• Hide .right-controls in XS player size via SCSS.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/components/bottom-bar/bottom-bar-utils.ts	Reverts overflow-controls calculation to remove the extra buffer factor.
src/components/bottom-bar/_bottom-bar.scss	Restores XS behavior by hiding the right controls container.

Suppressed comments (1)

src/components/bottom-bar/bottom-bar-utils.ts:12

• priorityPair is asserted as non-null but can be undefined when lowerPriorityControls contains no groups with length > 1 (or is empty). In that case controlsToRemove[controlsToRemove.length - 1] and priorityPair?.[0] can both be undefined, making the condition true and then priorityPair[1] throws at runtime. Guard priorityPair before indexing it (and drop the non-null assertion).

  const numOfOverflowControls = Math.ceil((currentMinBreakPointWidth - currentBarWidth) / currentControlWidth) || 1;
  const controlsToRemove = lowerPriorityControls.flat().slice(0, numOfOverflowControls);
  const priorityPair: string[] = [...lowerPriorityControls].reverse().find(p => p.length > 1)!;
  if (controlsToRemove[controlsToRemove.length - 1] === priorityPair?.[0]) {
    controlsToRemove.push(priorityPair[1]);

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.