fix(SUP-51711): Audio Description Language selection not working as expected in some browsers - #875
Merged
Conversation
SivanA-Kaltura
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes audio description language selection in cases where DASH metadata doesn’t provide enough information to reliably match audio tracks to flavors across browsers, by matching on label first and falling back to flavorId.
Changes:
- Update
audioDescriptionTrackHandlerto match audio flavors bylabelfirst, then fall back toflavorIdwhen label matching fails. - Add E2E test coverage for label-first matching, flavorId fallback behavior, and precedence rules.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/track/audio-track.ts |
Adjusts audio flavor matching logic to be label-first with a flavorId fallback to correctly detect audio description tracks. |
tests/e2e/track/audio-track-description.spec.js |
Adds test cases validating label vs flavorId matching precedence and expected audio description labeling outcomes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ravitshalem
approved these changes
May 3, 2026
SivanA-Kaltura
added a commit
to kaltura/playkit-js-dash
that referenced
this pull request
May 4, 2026
…xpected in some browsers (#271) ### Description of the Changes - Allow audio tracks with the same language. - Compute a stable audio track id without relying on getVariantTracks. - Use shaka getAudioTracks API to prepare for shaka v5 (where getVariantTracks and getAudioLanguagesAndRoles will be removed). Related PR: kaltura/playkit-js#875 Resolves [SUP-51711](https://kaltura.atlassian.net/browse/SUP-51711) [SUP-51711]: https://kaltura.atlassian.net/browse/SUP-51711?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Use label to compare audio flavor and track, fallback to flavorId if label comparison fails.
This is needed because dash provides us limited information for comparison.
Related PR:
kaltura/playkit-js-dash#271
Resolves SUP-51711
CheckLists