Add kamon-http4k server instrumentation - #1427
Open
souvlakias wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We have a service running
http4kand would like to use Kamon with it.Description
This PR adds a new
kamon-http4kserver instrumentation module, based on the structure and logic ofkamon-http4s-1.0(some files are mostly identical)Since
http4kis built around theFilterabstraction, the instrumentation is implemented as a backend-agnosticFilterthat works out-of-the-box with any backend (e.g. Netty, SunHttp, etc.).Tests included in
ServerInstrumentationSpecpass successfully.Additionally, a demo application that uses this feature can be found in this repo: https://github.com/vaslabs-ltd/kamon-http4k-poc.
cc: @vaslabs