Skip to content

Folder colour fix - #525

Open
s1-ranjan wants to merge 23 commits into
keeferrourke:masterfrom
s1-ranjan:Folder-colour
Open

s1-ranjan wants to merge 23 commits into
keeferrourke:masterfrom
s1-ranjan:Folder-colour

Conversation

@s1-ranjan

Copy link
Copy Markdown

Description

In this PR I am pushing Pink and Violet folder icons, which I find to be not properly mapped.

@keeferrourke

Copy link
Copy Markdown
Owner

Please remove the unrelated Mathematic icons from this PR.

@s1-ranjan

Copy link
Copy Markdown
Author

@keeferrourke will it not impact my previous contribution for the Mathematica icon?

@keeferrourke

Copy link
Copy Markdown
Owner

@s1-ranjan it will not! You can merge many independent changes without affecting others.

@s1-ranjan

Copy link
Copy Markdown
Author

@keeferrourke Please have a look and let the modification should go for merger.

@keeferrourke

Copy link
Copy Markdown
Owner

Just needs to be cleaned up, as outlined in the wiki. tidy and svgcleaner are your friends :)

@s1-ranjan

s1-ranjan commented Feb 18, 2020

Copy link
Copy Markdown
Author

yes both the packages has been executed, from my side

@keeferrourke

Copy link
Copy Markdown
Owner

I still see inkscape metadata in the diff though 🤔

@s1-ranjan

Copy link
Copy Markdown
Author

@keeferrourke can you please have a look now

@keeferrourke

Copy link
Copy Markdown
Owner

Still not good.

@s1-ranjan

Copy link
Copy Markdown
Author

@keeferrourke what about this icon pair?

@keeferrourke

Copy link
Copy Markdown
Owner

👌 now just run tidy as indicated here

@keeferrourke

Copy link
Copy Markdown
Owner

The magenta icon still needs to be cleaned as well.

@s1-ranjan

Copy link
Copy Markdown
Author

@keeferrourke Magenta?
Does you mean to say violet is ok

@s1-ranjan

Copy link
Copy Markdown
Author

I was just wondering and struggling with pink and violet icons, what about with other folder colours are they okay?

@s1-ranjan

Copy link
Copy Markdown
Author

Please have a look now

@s1-ranjan

Copy link
Copy Markdown
Author

@keeferrourke , may I push a new icon by making a new request?

@s1-ranjan s1-ranjan left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modification Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants