fix(security): consolidate 7.14.2 audit remediation - #473
Merged
BitHighlander merged 2 commits intoAug 27, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidated remediation for the frozen 7.14.2 release head after the latest cross-cutting signing audit.
The review also caught and fixed a new basis-point accumulator wrap case: 4294967296 could wrap to 0 and re-enter the accepted THOR/MAYA range.
Scope
This PR targets release/7.14.2-rc31, the head branch of parent PR #458.
Validation
The first exact-head CI run exposed four stale MakerDAO Python tests that still attempted contract-data signing without AdvancedMode. The companion update makes those vectors exercise the generic blind-signing path while retaining their deterministic signature checks. Exact-head CI is rerunning with that pin.
Release posture
This is a reviewable remediation PR, not release authorization. 7.14.2 remains NO-GO pending exact-head CI, the repeated frozen-head failure-class sweep with planted controls, independent approval, and the remaining hardware/storage gates. Nothing was signed, tagged, merged, or installed on hardware.