Skip to content

fix(security): consolidate 7.14.2 audit remediation - #473

Merged
BitHighlander merged 2 commits into
release/7.14.2-rc31from
fix/7142-consolidated-audit-remediation
Aug 27, 2026
Merged

fix(security): consolidate 7.14.2 audit remediation#473
BitHighlander merged 2 commits into
release/7.14.2-rc31from
fix/7142-consolidated-audit-remediation

Conversation

@BitHighlander

@BitHighlander BitHighlander commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Summary

Consolidated remediation for the frozen 7.14.2 release head after the latest cross-cutting signing audit.

  • fail closed before ButtonRequest when confirmation source formatting loses text
  • disclose SignIdentity index, curve, full path, and long visual challenges
  • remove legacy MakerDAO specialized clear-signing from the dispatcher
  • validate Osmosis display/JSON fields and canonical IBC numeric fields
  • tighten THORChain/MAYAChain structured memo tokens, byte grammar, and basis points
  • scrub canceled reset mnemonics and authenticator secrets/cache
  • make malformed continuations and second signing starts terminal
  • apply auto-lock while workflows wait on the host
  • add regression coverage for each failure class

The review also caught and fixed a new basis-point accumulator wrap case: 4294967296 could wrap to 0 and re-enter the accepted THOR/MAYA range.

Scope

This PR targets release/7.14.2-rc31, the head branch of parent PR #458.

Validation

  • clang-format 20: clean
  • git diff --check: clean
  • pinned container: kktech/firmware@sha256:7438e53933d47d53157ed6d96d864cb208597e62dce26235ace09d1063427fa2
  • firmware unit suite: 131/131 passed
  • board unit suite: 16/16 passed
  • crypto unit suite: 4/4 passed
  • the previously failing auto-lock test now passes with the initialized OLED harness
  • companion test syntax and offline-fixture manifest checks passed

The first exact-head CI run exposed four stale MakerDAO Python tests that still attempted contract-data signing without AdvancedMode. The companion update makes those vectors exercise the generic blind-signing path while retaining their deterministic signature checks. Exact-head CI is rerunning with that pin.

Release posture

This is a reviewable remediation PR, not release authorization. 7.14.2 remains NO-GO pending exact-head CI, the repeated frozen-head failure-class sweep with planted controls, independent approval, and the remaining hardware/storage gates. Nothing was signed, tagged, merged, or installed on hardware.

@BitHighlander
BitHighlander merged commit bcee122 into release/7.14.2-rc31 Aug 27, 2026
9 of 12 checks passed
@pastaghost
pastaghost deleted the fix/7142-consolidated-audit-remediation branch August 27, 2026 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant