Skip to content

Commit 004e33a

Browse files
committed
test(7.14.3): preserve legacy Osmosis release control
1 parent 146f341 commit 004e33a

1 file changed

Lines changed: 16 additions & 0 deletions

File tree

tests/test_msg_osmosis_validation.py

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,22 @@ def _assert_missing_parameter_failure(self, ack):
3131
self.assertEqual(ret.code, proto_types.Failure_FirmwareError)
3232
self.assertEndsWith(ret.message, "missing required parameters")
3333

34+
def test_present_but_empty_amount_is_rejected_before_review(self):
35+
# 7.14.3 treats a present-but-empty protobuf string as a missing
36+
# required parameter. Keep that release control explicit even though
37+
# 7.15 adds the stronger, syntax-specific rejection tested below.
38+
if self.firmware_at_least("7.15.0"):
39+
self.skipTest("7.15+ uses the syntax-specific empty amount gate")
40+
self._start_signing()
41+
send = osmosis_proto.OsmosisMsgSend(
42+
to_address="osmo1g9el7lzjwh9yun2c4jjzhy09j98vkhfx8tzcpt",
43+
amount="",
44+
denom="uosmo",
45+
)
46+
self.assertTrue(send.HasField("amount"))
47+
self._assert_missing_parameter_failure(
48+
osmosis_proto.OsmosisMsgAck(send=send))
49+
3450
def test_present_but_empty_amount_is_rejected_as_invalid(self):
3551
# The fail-closed empty-string validator is part of the 7.15 audit
3652
# fixes; 7.14.3 predates that specific Osmosis hardening.

0 commit comments

Comments
 (0)