Skip to content

Commit 216c238

Browse files
committed
test: describe host passphrase cancellation accurately
1 parent 2f6ecec commit 216c238

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

scripts/generate-test-report.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1281,9 +1281,9 @@ def junit_reconciliation(path):
12811281
('RP2', 'test_msg_ping', 'test_authenticator_passphrase_cancel_is_terminal',
12821282
'Authenticator cancellation is terminal',
12831283
'After PIN and passphrase prompts, Cancel must return Failure and Initialize must receive its own '
1284-
'Features response rather than a queued stale account Success. The randomized PIN grid and '
1285-
'device-side host-passphrase wait screen are retained; terminality is asserted on the wire.',
1286-
['PIN grid and passphrase wait']),
1284+
'Features response rather than a queued stale account Success. The randomized PIN grid is retained. '
1285+
'Passphrase entry is host-side and has no separate device approval screen; cancellation terminality '
1286+
'is asserted on the wire.', ['PIN grid before host passphrase entry']),
12871287
('RP3', 'Board', 'PostPreviewMutationChangesExactByteReview',
12881288
'Native exact-byte pager detects a tail mutation',
12891289
'The board-level control proves a mutation after the preview boundary changes the bytes reachable '

tests/test_msg_ping.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,6 @@ def test_authenticator_passphrase_cancel_is_terminal(self):
150150
self.assertIsInstance(resp, proto.PinMatrixRequest)
151151
resp = self.client.call_raw(self.client.callback_PinMatrixRequest(resp))
152152
self.assertIsInstance(resp, proto.PassphraseRequest)
153-
# Bind the terminal cancellation regression to the exact point where
154-
# the device is waiting for host passphrase entry.
155-
self.client._capture_oled()
156153
resp = self.client.call_raw(proto.Cancel())
157154
self.assertIsInstance(resp, proto.Failure)
158155
self.assertEqual(resp.code, proto_types.Failure_ActionCancelled)

0 commit comments

Comments
 (0)