test: bind 7.14.2 release evidence semantics

Author: BitHighlander

scripts/generate-test-report.py

@@ -104,7 +104,10 @@ def write(self, path):
         img_obj_ids = {}  # img_name -> obj_id
         for img_path, (name, pixels, iw, ih) in self.images.items():
             compressed = zlib.compress(pixels)
-            obj = f'{nxt} 0 obj\n<< /Type /XObject /Subtype /Image /Width {iw} /Height {ih} /ColorSpace /DeviceGray /BitsPerComponent 8 /Filter /FlateDecode /Length {len(compressed)} >>\nstream\n'.encode() + compressed + b'\nendstream\nendobj\n'
+            # The report verifier rasterizes at an integer OLED-pixel scale.
+            # State the PDF default explicitly so a reader cannot smooth a
+            # security frame and make the final visible pixels ambiguous.
+            obj = f'{nxt} 0 obj\n<< /Type /XObject /Subtype /Image /Width {iw} /Height {ih} /ColorSpace /DeviceGray /BitsPerComponent 8 /Interpolate false /Filter /FlateDecode /Length {len(compressed)} >>\nstream\n'.encode() + compressed + b'\nendstream\nendobj\n'
             objs.append(obj)
             img_obj_ids[name] = nxt
             nxt += 1
@@ -363,10 +366,141 @@ def junit_reconciliation(path):
     ('test_msg_resetdevice', 'test_reset_device_24_words'): 7,
     ('test_msg_resetdevice', 'test_reset_device_pin'): 6,
     ('test_msg_resetdevice', 'test_failed_pin'): 2,
+    ('test_msg_recoverydevice_cipher', 'test_nopin_nopassphrase'): 43,
+    ('test_msg_recoverydevice_cipher', 'test_pin_passphrase'): 45,
+    ('test_msg_changepin', 'test_set_pin'): 3,
+    ('test_msg_changepin', 'test_change_pin'): 4,
+    ('test_msg_changepin', 'test_remove_pin'): 2,
+    ('test_msg_ethereum_signtx', 'test_ethereum_blind_sign_blocked'): 1,
     ('test_msg_ping', 'test_authenticator_passphrase_cancel_is_terminal'): 1,
     ('test_msg_solana_signtx', 'test_solana_sign_system_transfer'): 3,
 }
 
+# Counts and unique whole-frame hashes reject missing pages and stale capture,
+# but a same-sized set of unrelated screens could still be relabelled as the
+# ceremony. Pin stable semantic regions: static prompts in full, seed-page
+# titles without random words, and PIN/recovery labels without randomized
+# grids. Values are raw 8-bit framebuffer-region SHA-256 digests, not PNG file
+# hashes, so metadata/encoding changes cannot satisfy them.
+_RECOVERY_PROGRESS_DIGESTS = (
+    '356da6d4365dc08dc554d7d14d82c6458cd4812682ebcf16521154582c201c9d',
+    'bd5c4a4e92abb097d0c5f69176d915568b483a5bc1c98e17ba8c26e35bc6e308',
+    '3cf4d797c321cf56e63c177f64e6d889358fed8f6dd1cecd658b90621c10df8d',
+    'ac4b89a3020e9c9bc12dc630f95d96e5ac86d381cfad71843aa88835d82f42de',
+    'dd30561c70c73b39733b6d71d6cbea89d43a81cf032cbed7e013a4a93694d709',
+    'b6e134f114a1572da2464780eca206a422f31de5f2699ae8979e89c0e3c70825',
+    '98712d58cb5f17fda59d73cd37c33c6e81ffe011eeb2fbc9bf530a2b8effc052',
+    '2e9ac61c8da62ed071b8ba9ede76ca1df45d52684ddc0b8192e57ae485aa2d14',
+    'ffc90a573947af63fb0700a9b7e4d105ef02cfbda1077f9e0da61fd7d5dbecc0',
+    '6ea6b5da97c73890c2c304d92a08807b4c1f86cd22f35d8011ac9b16545f1e26',
+    'fe736b5dc3d03ac1beab86df27aec6a8493e8f53776889fcf64afd4ea9b99f8c',
+    '508ccfc1207a64f4c13cb08d5068cbd20aff4070213ff39b14beaa3d7e5b291c',
+    '46cdc4cde98844b548431ce166ff7ce9d044f3d2b3f6cf073bc6f5e6991c64c5',
+    '15ab192e8fb5ad155072a686cf8141b9c031bac561368b090ef03f48fe20be41',
+    'd96df49ded78365e8d5670d37b2013eb1b15be148f0de3fa24e01749bcf40799',
+    '8a0857857a5fc98d395229b6f0551a784e60ec7503450d1ff6703c43e93bedf0',
+    '1d2f9d8b4d89fc531e22ab8861ca8c4855e1e782b45f9e8a94ef18fccc8abc24',
+    'fb2f1a2e4bf6a55ba80b3ea93ac7f4a4d920d92947fdda5e19b4f36d8ca97c39',
+    '8baf086979d10099db857889f5e98870b69b533dbb6ad8223759012bfb1883fd',
+    '4871fb187d2c5d18fab2ff733e44877c4be255b889e5d92809e5c96a764977c7',
+    'ab63aefd9107d312e155446f1d3b6885408c72f81100bcbe15018ffa10bd2323',
+    'eecaca7c1159ab9cd9050efd48c6fa2d041fa968b90a36020639723368ae619b',
+    '0add6eea0290f825a0a96d55859192fa17f91ba641d0acba3aae0da1d82013da',
+    '613fafd7d89e66bdc6b3df8929ae8189d0628e8fedad164a68dab0d524973f42',
+    '1bb1ef1cadc2c771ef6ae2cc439cde1c96d54b2dfbfc5c797ccdaab96cea9217',
+    '0fb5c836d9399a7842a9bfefcdc4e98e9f0beba73fa6a9ddf9fb6d20a45c557a',
+    'b1872159d11592ba047fffad4c6d4afeb9f08d63efb1da08db4bf7a7333652fa',
+    '766f7c35fb85b92a63d53f38d85209cacc2c77896a971ce6404069334c985832',
+    '0037fe837403c31e8afc3dcdcabe59749d827b2056e976e60911c820633a1138',
+    '1838b5b983fa4ce45b18ee42d6f6eb265a04242bb4d49a731e44c06ee05c0e6f',
+    '06f177d53c810c8ebaf39183960dba6d516bc4d614e31e3d54d2806d87a53373',
+    'ac8c1ae7c3106d13467784442149a923b538d2496de6112859a6a9aa35aba9e0',
+    'ef8f79330bfc7c1433cef9f4bbaa72553187405b6dc953a0289bc23588a89ba5',
+    'd9beba0b50498295a17d0574af5319340a49c9b0eb584fc6a692bdb8de61120c',
+    'cdf9f82d26cc510be4245de86eea8d15d475fc7188cad2313985817393c5e98f',
+    '698e4369c80ededc84089de96e3ce3f75d6e5a0fe0f948c170a72b52596cff18',
+    'c24ab48b79202080b794e6bbe08fd1addeb3d464d350f8ab870d16d65cbfd892',
+    '0f132132d36b77080285577210c9584041e96fdadb43ff1623c0a76321bc1ac8',
+    'cac9864396459cd742266d587c3a4668c83e30cb5c4586c80c8d4467f12b7c29',
+    '73e185aed618ea31559e32571350d5994ed1a8548ed242c0aea04b3e928a20b6',
+    'ce7b85a3ab8faa6e04cbaecdc8c26a7afef950c371bf39b5480de3e7b21ab715',
+    'c511560f884aa174d6980fbc2494daa5e21cf3a2b3c9fefd58a3d52fa2b91990',
+)
+SECURITY_STAGE_POLICIES = {
+    ('test_msg_resetdevice', 'test_reset_device'): (
+        ((0, 0, 256, 64), 'be76f41dcbb2699274234cc687ae2a136cc23ee57e2b16ebc94a5c95c07d62d5'),
+        ((0, 0, 256, 16), '9ae3b8815317cf35882cbbdd8129bc6fa79c029759edce8cf64103f291809d05'),
+        ((0, 0, 256, 16), '9c70c1af5f9a4da9b6aa69c3beefc5e3c70d82af51212350e757bfd9cabf36de'),
+        ((0, 0, 256, 16), '88e1755feef35658a506016ea50ed1ba5a651d53e1a98dd97f07282ca22c77ef'),
+    ),
+    ('test_msg_resetdevice', 'test_reset_device_18_words'): (
+        ((0, 0, 256, 64), 'be76f41dcbb2699274234cc687ae2a136cc23ee57e2b16ebc94a5c95c07d62d5'),
+        ((0, 0, 256, 16), '5e967b430c4f07a0f8f8dc7594eaa66be7237f3baf41a90f7a5edd9e88912474'),
+        ((0, 0, 256, 16), 'e58ece0276ba86987987ab6fdfd0a12e4ed7dd8478dfe9ed7249a516c8063d69'),
+        ((0, 0, 256, 16), '1669d638b7256699b9ed57615619e365fb4ab67a7c8a6f2ed8b23d758da43027'),
+        ((0, 0, 256, 16), 'b259422a2db01225278f22bf43e7a60969aa202a260b11d2c91b44f5764cbac8'),
+        ((0, 0, 256, 16), 'd4e6ed9a13a1bf88a662d7568094d5a66d2bdbd9ac39f3a576f59108b0578515'),
+    ),
+    ('test_msg_resetdevice', 'test_reset_device_24_words'): (
+        ((0, 0, 256, 64), 'be76f41dcbb2699274234cc687ae2a136cc23ee57e2b16ebc94a5c95c07d62d5'),
+        ((0, 0, 256, 16), '2fb7530c04acb560dbe1a29179bb084bd7003846a9204b26152c363f2fa076ac'),
+        ((0, 0, 256, 16), '46c79190446218f6b33ac2e1cf0407c37fc680db911dff5ad61c27459157dd9b'),
+        ((0, 0, 256, 16), '5e2f25cd0c1e4b6d41fe42316b6f696f747636b7446f33f0b853f322f397e628'),
+        ((0, 0, 256, 16), '934e043c7691ea2bd1e3126da5add2e907f1b9e4d9ae183bba34b0227c69e724'),
+        ((0, 0, 256, 16), '68b48e9ca14c309b3953afe4f0f0c0f289a4a0fa7920d4c5188562754c294d2e'),
+        ((0, 0, 256, 16), 'd0f315000890dce0317553c695a2bd72e8bbb67a28d3640812c7a93945bd2882'),
+    ),
+    ('test_msg_resetdevice', 'test_reset_device_pin'): (
+        ((0, 0, 72, 64), '41cf35c908d63d6f350edbcf0d70f504dd35142906c85402f108c373c37264bc'),
+        ((0, 0, 72, 64), '42775a67b27b34e34bea67aa17a8942eb2bc28215cd5dd8d31c3562f556393db'),
+        ((0, 0, 256, 64), 'be76f41dcbb2699274234cc687ae2a136cc23ee57e2b16ebc94a5c95c07d62d5'),
+        ((0, 0, 256, 16), '9ae3b8815317cf35882cbbdd8129bc6fa79c029759edce8cf64103f291809d05'),
+        ((0, 0, 256, 16), '9c70c1af5f9a4da9b6aa69c3beefc5e3c70d82af51212350e757bfd9cabf36de'),
+        ((0, 0, 256, 16), '88e1755feef35658a506016ea50ed1ba5a651d53e1a98dd97f07282ca22c77ef'),
+    ),
+    ('test_msg_resetdevice', 'test_failed_pin'): (
+        ((0, 0, 72, 64), '41cf35c908d63d6f350edbcf0d70f504dd35142906c85402f108c373c37264bc'),
+        ((0, 0, 72, 64), '42775a67b27b34e34bea67aa17a8942eb2bc28215cd5dd8d31c3562f556393db'),
+    ),
+    ('test_msg_recoverydevice_cipher', 'test_nopin_nopassphrase'):
+        (((0, 0, 256, 64), '2130e48943d0894d27d00ecc015e9cb15ea8be96044d823ef9b8b6e64897a0d8'),) +
+        tuple(((0, 32, 72, 64), digest)
+              for digest in _RECOVERY_PROGRESS_DIGESTS),
+    ('test_msg_recoverydevice_cipher', 'test_pin_passphrase'):
+        (((0, 0, 72, 64), '41cf35c908d63d6f350edbcf0d70f504dd35142906c85402f108c373c37264bc'),
+         ((0, 0, 72, 64), '42775a67b27b34e34bea67aa17a8942eb2bc28215cd5dd8d31c3562f556393db'),
+         ((0, 0, 256, 64), '2130e48943d0894d27d00ecc015e9cb15ea8be96044d823ef9b8b6e64897a0d8')) +
+        tuple(((0, 32, 72, 64), digest)
+              for digest in _RECOVERY_PROGRESS_DIGESTS),
+    ('test_msg_changepin', 'test_set_pin'): (
+        ((0, 0, 256, 64), 'a1181d01ad8cdf156f4d082ad1a976b2d83b863da99ce75fd007053775fb89b9'),
+        ((0, 0, 72, 64), '41cf35c908d63d6f350edbcf0d70f504dd35142906c85402f108c373c37264bc'),
+        ((0, 0, 72, 64), '42775a67b27b34e34bea67aa17a8942eb2bc28215cd5dd8d31c3562f556393db'),
+    ),
+    ('test_msg_changepin', 'test_change_pin'): (
+        ((0, 0, 256, 64), '8358abe3b90dff94b248cf5577758538d9ed6abd8f299c53cb6b452f27beb8f2'),
+        ((0, 0, 72, 64), 'e5addc208c68cf1655e2aa00789159a3039b6a27e18df9891c88fcfe1af71219'),
+        ((0, 0, 72, 64), '41cf35c908d63d6f350edbcf0d70f504dd35142906c85402f108c373c37264bc'),
+        ((0, 0, 72, 64), '42775a67b27b34e34bea67aa17a8942eb2bc28215cd5dd8d31c3562f556393db'),
+    ),
+    ('test_msg_changepin', 'test_remove_pin'): (
+        ((0, 0, 256, 64), '4e0e3515ea141409fe932778a59fe2c4007d8074aa4469e5fba5f4a8527d0c98'),
+        ((0, 0, 72, 64), 'e5addc208c68cf1655e2aa00789159a3039b6a27e18df9891c88fcfe1af71219'),
+    ),
+    ('test_msg_ethereum_signtx', 'test_ethereum_blind_sign_blocked'): (
+        ((0, 0, 80, 16),
+         'f0d262606b7358aee6b8c9d9dfac9035f89bd8a8b26b2551c11561731b47880d'),
+    ),
+    ('test_msg_ping', 'test_authenticator_passphrase_cancel_is_terminal'): (
+        ((0, 0, 72, 64), 'e5addc208c68cf1655e2aa00789159a3039b6a27e18df9891c88fcfe1af71219'),
+    ),
+    ('test_msg_solana_signtx', 'test_solana_sign_system_transfer'): (
+        ((0, 0, 128, 32), '7c497cdbcbab7e37c4bc0ad6a0276b18cfe4b8744689cad0d6afa37b09b7b37c'),
+        ((0, 0, 80, 32), '6229b9bc36eed4e5dece1deafdcb44e3b6449f7c1329fef3797bea609dad4b8f'),
+        ((0, 0, 256, 64), '0f1acb8bc327fed89037093f9b489a8ce598c8f58d26601ae0d618c03403e823'),
+    ),
+}
+
 SECURITY_DISTINCT_FRAME_TESTS = set(SECURITY_FRAME_POLICIES) | {
     ('test_msg_solana_instruction_disclosure',
      'test_all_verified_instruction_fields_change_oled_review'),
@@ -468,8 +602,8 @@ def junit_reconciliation(path):
          '- an unresolved token rendered as the literal "Unknown token value" and signed',
          '- a truncated memo dropped its last character (Confirm limit 42 vs 420)',
          '',
-         'A test here with an EMPTY screenshot list is deliberate: refusal paths draw nothing,',
-         'and their evidence is the Failure on the wire plus the absence of a ButtonRequest.',
+         'An EMPTY screenshot list is valid only for a refusal that asserts no ButtonRequest.',
+         'A refusal that emits a policy notice must retain that frame and its exact wire order.',
      ],
      [
          ('DB1', 'test_msg_ethereum_erc20_0x_signtx', 'test__sign_transformERC20',
@@ -582,16 +716,17 @@ def junit_reconciliation(path):
     ('X', 'Device Specifications', '0.0.0',
      'The KeepKey is an open-source hardware wallet built on an ARM Cortex-M3 (STM32F205, 120MHz) '
      'with a 256x64 monochrome OLED, single confirmation button, and micro-USB interface. The '
-     'bootloader (v2.x) is flashed at manufacture and never updated - it is the immutable root of '
-     'trust. On every boot, the bootloader verifies the firmware signature using redundant F3 checks '
-     'before transferring control.',
+     'bootloader (v2.x) verifies the firmware signature using redundant F3 checks before transferring '
+     'control. Bootloader updates are supported through a separately built updater and therefore '
+     'remain a security-sensitive release path; the bootloader must not be described as immutable.',
      [
          'BOOT SEQUENCE:',
          '1. USB connect -> bootloader executes (always first)',
          '2. F3 signature check (redundant dual-path verify)',
          '3. Valid -> KeepKey logo -> firmware runs',
          '4. Invalid/missing -> "UPDATE FIRMWARE" screen',
          '5. Firmware upload -> verify -> flash -> reboot -> re-verify',
+         '6. Bootloader updates use the separately audited blupdater artifact',
          '',
          'HARDWARE:',
          '- MCU: STM32F205RET6, 120MHz, 128KB bootloader + 896KB firmware',
@@ -934,9 +1069,12 @@ def junit_reconciliation(path):
           ['ETH send confirmation']),
          ('E3', 'test_msg_ethereum_signtx', 'test_ethereum_signtx_data',
           'Sign ETH tx with contract data',
-          'Transaction with data field (contract call). Device shows data as hex since it cannot '
-          'decode arbitrary ABI without metadata.',
-          ['Contract data hex']),
+          'Transaction with a data field (contract call). Without trusted metadata the device does '
+          'not show raw calldata as decoded semantics: AdvancedMode is required and the OLED shows '
+          'the complete-calldata Keccak-256 commitment with the transaction fields. This test signs '
+          'three contract-call variants in sequence; repeated amount/hash/fee frames are intentional '
+          'per-variant approvals, not one duplicated approval flow.',
+          ['Contract data hash and transaction fields for three variants']),
          ('E4', 'test_msg_ethereum_signtx', 'test_ethereum_signtx_nodata_eip155',
           'Sign ETH with EIP-155 replay protection',
           'Chain ID embedded in signature v value to prevent cross-chain replay attacks.', []),
@@ -1150,9 +1288,10 @@ def junit_reconciliation(path):
           ['Opaque policy warning', 'Complete calldata hash approval']),
          ('V9', 'test_msg_ethereum_signtx', 'test_ethereum_blind_sign_blocked',
           'Opaque contract data blocked (AdvancedMode OFF)',
-          'On 7.14.2 the same arbitrary calldata is refused by policy before any signing approval. '
-          'The wire Failure and absence of a signing ButtonRequest are the evidence.',
-          []),
+          'On 7.14.2 the same arbitrary calldata produces one non-approving Blocked notice, then '
+          'Failure_ActionCancelled. The exact two-message sequence proves there is no signing '
+          'approval after the policy notice.',
+          ['Blocked policy notice']),
      ]),
 
     ('SOL', 'Solana', '7.14.0',
@@ -1780,6 +1919,23 @@ def _sequence_record(screenshot_root, directory, label, frames):
     }
 
 
+def _validate_security_stage_digests(mod, meth, stage_policy,
+                                     actual_digests):
+    """Bind each ceremony position to its expected visible semantic stage."""
+    if len(stage_policy) != len(actual_digests):
+        raise ValueError(
+            'security ceremony semantic-stage count mismatch for %s::%s' %
+            (mod, meth))
+    for index, (actual, stage) in enumerate(zip(
+            actual_digests, stage_policy)):
+        _region, expected = stage
+        allowed = (expected,) if isinstance(expected, str) else expected
+        if actual not in allowed:
+            raise ValueError(
+                'security ceremony frame %d has the wrong semantic stage '
+                'for %s::%s' % (index, mod, meth))
+
+
 def _enforce_security_frame_policy(directory, mod, meth, frames):
     expected_count = SECURITY_FRAME_POLICIES.get((mod, meth))
     if expected_count is not None and len(frames) != expected_count:
@@ -1797,6 +1953,28 @@ def _enforce_security_frame_policy(directory, mod, meth, frames):
         raise ValueError(
             'security ceremony contains a duplicate framebuffer for %s::%s' %
             (mod, meth))
+    stage_policy = SECURITY_STAGE_POLICIES.get((mod, meth))
+    if stage_policy is None:
+        return
+    actual_digests = []
+    for index, (frame, stage) in enumerate(zip(frames, stage_policy)):
+        region, expected = stage
+        x0, y0, x1, y1 = region
+        try:
+            pixels, width, height = _read_png_pixels(
+                os.path.join(directory, frame))
+        except Exception as exc:
+            raise ValueError(
+                'security ceremony frame %d is not a valid framebuffer: %s' %
+                (index, exc))
+        if not (0 <= x0 < x1 <= width and 0 <= y0 < y1 <= height):
+            raise ValueError('invalid security semantic region')
+        cropped = b''.join(
+            pixels[y * width + x0:y * width + x1]
+            for y in range(y0, y1))
+        actual_digests.append(hashlib.sha256(cropped).hexdigest())
+    _validate_security_stage_digests(
+        mod, meth, stage_policy, actual_digests)
 
 
 def selected_screenshot_sequences(screenshot_root, mod, meth, wants_screens):

tests/test_msg_ethereum_signtx.py

@@ -101,29 +101,42 @@ def test_ethereum_signtx_data(self):
     def test_ethereum_blind_sign_blocked(self):
         """AdvancedMode OFF + contract data = device refuses to sign (7.14.2+).
 
-        OLED explains that arbitrary contract data requires AdvancedMode, then
-        the device returns the policy failure without requesting approval.
+        The device displays one non-approving Blocked notice, then returns the
+        policy failure. The exact ButtonRequest -> Failure sequence proves the
+        host cannot advance from that notice into a signing approval.
         """
         self.requires_firmware("7.14.2")
         self.requires_fullFeature()
         self.setup_mnemonic_nopin_nopassphrase()
         self.client.apply_policy("AdvancedMode", 0)
 
-        try:
-            self.client.ethereum_sign_tx(
-                n=[0, 0],
-                nonce=0,
-                gas_price=20,
-                gas_limit=20,
-                to=binascii.unhexlify("1d1c328764a41bda0492b66baa30c4a339ff85ef"),
-                value=0,
-                data=b"abcdefghijklmnop" * 16,
-                chain_id=1,
-            )
-            self.fail("Expected Failure -- blind signing should be blocked")
-        except CallException as e:
-            self.assertIn("Arbitrary contract data signing disabled by policy",
-                          str(e))
+        with self.client:
+            self.client.set_expected_responses([
+                proto.ButtonRequest(
+                    code=proto_types.ButtonRequest_Other),
+                proto.Failure(
+                    code=proto_types.Failure_ActionCancelled,
+                    message=(
+                        "Arbitrary contract data signing disabled by policy")),
+            ])
+            try:
+                self.client.ethereum_sign_tx(
+                    n=[0, 0],
+                    nonce=0,
+                    gas_price=20,
+                    gas_limit=20,
+                    to=binascii.unhexlify(
+                        "1d1c328764a41bda0492b66baa30c4a339ff85ef"),
+                    value=0,
+                    data=b"abcdefghijklmnop" * 16,
+                    chain_id=1,
+                )
+                self.fail(
+                    "Expected Failure -- blind signing should be blocked")
+            except CallException as e:
+                self.assertIn(
+                    "Arbitrary contract data signing disabled by policy",
+                    str(e))
 
     def test_ethereum_blind_sign_allowed(self):
         """AdvancedMode ON permits opaque contract-data signing (7.14.2+).