test(ethereum): pin native pseudo-address isolation

Author: BitHighlander

scripts/generate-test-report.py

@@ -1168,19 +1168,29 @@ def junit_cases(path):
           'ERC-20 transfer chain-ID width binding',
           'TRANSFER review scopes token metadata to the complete chain ID.',
           ['Chain 1 and chain 257 transfer sequences']),
-         ('R20', 'test_msg_osmosis_validation',
+         ('R20', 'test_msg_ethereum_signtx',
+          'test_ethereum_native_pseudo_address_is_unknown_off_mainnet',
+          'ERC-20 native pseudo-address isolation',
+          'Chain 257 transfer and approve calls render the exact unknown-token frame.',
+          ['Transfer and approve unknown-token sequences']),
+         ('R21', 'test_msg_ethereum_signtx_xfer',
+          'test_native_pseudo_address_transfer_is_unknown_off_mainnet',
+          'ERC-20 TRANSFER pseudo-address isolation',
+          'TRANSFER review renders 0xeeee..eeee as unknown outside chain 1.',
+          ['Exact unknown-token transfer sequence']),
+         ('R22', 'test_msg_osmosis_validation',
           'test_present_but_empty_amount_is_rejected_before_review',
           'Osmosis empty amount refusal', 'Present-but-empty is not displayed as zero.', []),
-         ('R21', 'test_msg_osmosis_validation',
+         ('R23', 'test_msg_osmosis_validation',
           'test_ibc_omitted_amount_and_receiver_are_rejected_before_review',
           'Osmosis IBC required fields', 'Omitted value and receiver are refused.', []),
-         ('R22', 'test_msg_recoverydevice_cipher',
+         ('R24', 'test_msg_recoverydevice_cipher',
           'test_unknown_word_count_failure_aborts_recovery',
           'Recovery Failure is terminal', 'A stale CharacterAck cannot resume the ceremony.', []),
-         ('R23', 'test_msg_signing_boundaries',
+         ('R25', 'test_msg_signing_boundaries',
           'test_multisig_signature_over_72_bytes_is_rejected',
           'Multisig serialization bound', 'Oversized host signatures are refused.', []),
-         ('R24', 'test_msg_signing_boundaries',
+         ('R26', 'test_msg_signing_boundaries',
           'test_clear_session_aborts_active_bitcoin_signing',
           'ClearSession ends signing', 'A stale TxAck cannot resume the signer.', []),
      ]),

tests/test_msg_ethereum_signtx.py

@@ -21,6 +21,7 @@
 import unittest
 import common
 import binascii
+import hashlib
 
 import keepkeylib.messages_pb2 as proto
 import keepkeylib.messages_ethereum_pb2 as eth_proto
@@ -31,6 +32,49 @@
 
 
 class TestMsgEthereumSigntx(common.KeepKeyTest):
+    def test_ethereum_native_pseudo_address_is_unknown_off_mainnet(self):
+        """0xeeee..eeee must render as unknown for chain-257 token calls."""
+        self.requires_firmware("7.14.2")
+        self.requires_fullFeature()
+        self.setup_mnemonic_nopin_nopassphrase()
+        self.client.apply_policy("AdvancedMode", 1)
+        common.reset_screenshot_capture(self.client)
+
+        recipient = self.client.ethereum_get_address([0, 0])
+        pseudo_address = b"\xee" * 20
+        calls = (
+            (
+                "transfer",
+                binascii.unhexlify("a9059cbb" + "00" * 12) +
+                recipient + int_to_big_endian(1).rjust(32, b"\x00"),
+                "85d9054ee56836c1784c90dd777fc89444bf82b840d0818a59c73aa5b57ee35d",
+            ),
+            (
+                "approve",
+                binascii.unhexlify("095ea7b3" + "00" * 12) +
+                recipient + int_to_big_endian(1).rjust(32, b"\x00"),
+                "ab30156ff400957ffa9146ea827318bf878614e6ab4ae7dd731824e285fa5da6",
+            ),
+        )
+
+        try:
+            for label, data, expected_frame_sha256 in calls:
+                with ScreenRecorder(
+                        self.client,
+                        screenshot_group="pseudo-%s" % label) as recorder:
+                    self.client.ethereum_sign_tx(
+                        n=[0, 0], nonce=0, gas_price=20, gas_limit=60000,
+                        to=pseudo_address, value=0, chain_id=257, data=data,
+                    )
+                self.assertGreaterEqual(len(recorder.screens), 2)
+                self.assertEqual(
+                    hashlib.sha256(recorder.screens[0]).hexdigest(),
+                    expected_frame_sha256,
+                )
+        finally:
+            self.client.apply_policy("AdvancedMode", 0)
+            common.reset_screenshot_capture(self.client)
+
     def test_ethereum_erc20_high_chain_id_does_not_alias_mainnet(self):
         """Chain 257 must not borrow chain-1 token labels or decimals."""
         self.requires_firmware("7.14.2")

tests/test_msg_ethereum_signtx_xfer.py

@@ -21,6 +21,7 @@
 import unittest
 import common
 import binascii
+import hashlib
 import struct
 
 import keepkeylib.messages_pb2 as proto
@@ -29,7 +30,44 @@
 from keepkeylib.tools import int_to_big_endian
 from test_msg_display_disclosure import ScreenRecorder
 
+
 class TestMsgEthereumSigntx(common.KeepKeyTest):
+    def test_native_pseudo_address_transfer_is_unknown_off_mainnet(self):
+        """TRANSFER must show the exact unknown-token frame on chain 257."""
+        self.requires_firmware("7.14.2")
+        self.requires_fullFeature()
+        self.setup_mnemonic_nopin_nopassphrase()
+        self.client.apply_policy('ShapeShift', 1)
+        self.client.apply_policy('AdvancedMode', 1)
+        common.reset_screenshot_capture(self.client)
+
+        destination_n = [0x8000002c, 0x8000003c, 0x80000001, 0, 0]
+        recipient = self.client.ethereum_get_address(destination_n)
+        erc20_data = (
+            binascii.unhexlify("a9059cbb" + "00" * 12) +
+            recipient + int_to_big_endian(1).rjust(32, b"\x00")
+        )
+
+        try:
+            with ScreenRecorder(
+                    self.client,
+                    screenshot_group="pseudo-transfer") as recorder:
+                self.client.ethereum_sign_tx(
+                    n=[0, 0], nonce=0, gas_price=20, gas_limit=60000,
+                    value=0, to=b"\xee" * 20, to_n=destination_n,
+                    address_type=proto_types.TRANSFER,
+                    data=erc20_data, chain_id=257,
+                )
+            self.assertGreaterEqual(len(recorder.screens), 2)
+            self.assertEqual(
+                hashlib.sha256(recorder.screens[0]).hexdigest(),
+                "b0a3026e7af1778ebd71a968ace25c03945cccf2d8abc951e5dd65abc04e914e",
+            )
+        finally:
+            self.client.apply_policy('AdvancedMode', 0)
+            self.client.apply_policy('ShapeShift', 0)
+            common.reset_screenshot_capture(self.client)
+
     def test_transfer_review_uses_signing_chain_asset(self):
         """The first transfer approval must change with the signed chain."""
         self.requires_firmware("7.14.2")