test: discard OLED residue from skipped cases

Author: BitHighlander

tests/conftest.py

@@ -14,6 +14,7 @@
 import glob
 import hashlib
 import json
+import shutil
 import socket
 import sys
 
@@ -50,6 +51,23 @@ def pytest_collection_modifyitems(config, items):
         config.hook.pytest_deselected(items=deselected)
     items[:] = selected
 
+
+def _screenshot_dir_for_item(item):
+    module = os.path.splitext(os.path.basename(item.location[0]))[0]
+    method = getattr(item, 'originalname', None) or item.name.split('[', 1)[0]
+    return os.path.join(
+        os.environ.get('SCREENSHOT_DIR', 'screenshots'),
+        module.replace('test_', '', 1), method)
+
+
+@pytest.hookimpl(hookwrapper=True)
+def pytest_runtest_makereport(item, call):
+    """A skipped case must never retain setup/policy frames as evidence."""
+    outcome = yield
+    report = outcome.get_result()
+    if (os.environ.get('KEEPKEY_SCREENSHOT') == '1' and report.skipped):
+        shutil.rmtree(_screenshot_dir_for_item(item), ignore_errors=True)
+
 if os.environ.get('KEEPKEY_SCREENSHOT') == '1':
     import common