Commit 83c3ed2
committed
fix(test): LAST_SHIPPED stays 17 until 7.16 actually ships
My own U5 update asserted STORAGE_VERSION_LAST_SHIPPED == 20, which is wrong in
the specific way storage.h warns about two lines above the constant:
"Bump this baseline when a release ships, in the release commit, never to
make a build compile: lowering it is the exact edit that turns every
upgrade in the field into a silent wipe."
LAST_SHIPPED is the high-water mark of what is IN THE FIELD, not of what sits
in the tree. 7.15 shipped V17; 7.16 has shipped nothing. Asserting 20 would
have forced the next person to raise the baseline to make the test pass -- the
edit the gate exists to prevent, arrived at by way of the gate itself.
The compile-time assert only requires STORAGE_VERSION >= LAST_SHIPPED, and
20 >= 17 holds, so the raise was never needed. It moves in the release commit
that tags 7.16.1 parent fa4898d commit 83c3ed2
1 file changed
Lines changed: 12 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
442 | 442 | | |
443 | 443 | | |
444 | 444 | | |
445 | | - | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
446 | 457 | | |
447 | 458 | | |
448 | 459 | | |
| |||
0 commit comments