Skip to content

Commit e24c3b0

Browse files
committed
test(thorchain,maya): repin the add-liquidity signatures for the corrected memo length
The previous commit fixed the ABI memo length word from 59 to 58, which changes the calldata and therefore the signature. New values, for both files: sig_v 37 (unchanged) sig_r 7adc5bda6e66b37a81962557c844509c4bfaa1e9217fc6d05968286d60b67dbf sig_s 613479150c4cfbcdc8243055aa5137afc89826c4176c420a60409f139171831b Not copied out of a failure message. The r value was produced twice independently -- by CI's emulator, and by signing the corrected calldata on a physical KeepKey running signed v7.14.1 with the same public test seed. Two signers, same result, which is what makes repinning safe rather than circular. ECDSA here is RFC6979 deterministic, so agreement is the expected outcome and disagreement would have meant the change was wrong. The sibling eth_btc_swap fixtures are untouched: their memo genuinely is 59 bytes, their length word is right, and their signatures still hold.
1 parent cd559c9 commit e24c3b0

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

tests/test_msg_mayachain_signtx.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,8 @@ def test_sign_eth_add_liquidity(self):
140140

141141
)
142142
self.assertEqual(sig_v, 37)
143-
self.assertEqual(hexlify(sig_r), '638f9f42c099d0d47f7fc70d248249d2db24ecabc2fdee5bf2f5ad73b5bbfd30')
144-
self.assertEqual(hexlify(sig_s), '3dae036aabbe0ec55f7b9e4eef54e2b5335f62544d8c2ed041797a9397f185c7')
143+
self.assertEqual(hexlify(sig_r), '7adc5bda6e66b37a81962557c844509c4bfaa1e9217fc6d05968286d60b67dbf')
144+
self.assertEqual(hexlify(sig_s), '613479150c4cfbcdc8243055aa5137afc89826c4176c420a60409f139171831b')
145145

146146
@unittest.skip("TODO: capture expected signatures from emulator")
147147
def test_mayachain_remove_liquidity(self):

tests/test_msg_thorchain_signtx.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,8 @@ def test_sign_eth_add_liquidity(self):
141141

142142
)
143143
self.assertEqual(sig_v, 37)
144-
self.assertEqual(hexlify(sig_r), '638f9f42c099d0d47f7fc70d248249d2db24ecabc2fdee5bf2f5ad73b5bbfd30')
145-
self.assertEqual(hexlify(sig_s), '3dae036aabbe0ec55f7b9e4eef54e2b5335f62544d8c2ed041797a9397f185c7')
144+
self.assertEqual(hexlify(sig_r), '7adc5bda6e66b37a81962557c844509c4bfaa1e9217fc6d05968286d60b67dbf')
145+
self.assertEqual(hexlify(sig_s), '613479150c4cfbcdc8243055aa5137afc89826c4176c420a60409f139171831b')
146146

147147
def test_thorchain_remove_liquidity(self):
148148
self.requires_fullFeature()

0 commit comments

Comments
 (0)