Commit e60ce4f
committed
ci(circleci): stop gating python-keepkey on the firmware's C++ suite
The job ran the firmware's firmware-unit suite alongside this repo's tests and
failed if EITHER reported non-zero. No change in this repository can affect
firmware C++, and the firmware repo already runs that suite in its own CI, so
the only thing it contributed was failing python-keepkey for reasons no python
change caused.
It is failing that way right now: this branch trims the built-in token table,
which requires a matching firmware change to tokens.def. The job clones
firmware master, so it cannot go green until that change reaches master -- a
release away -- even though this repo's own suite passes 417/0.
Also hardens the verdict. The old check was
[ "$(cat test-reports/python-keepkey/status)$(cat .../firmware-unit/status)" = "00" ]
which printed 'cat: ... No such file or directory' and compared an empty string
whenever a container died before writing its status -- so a crashed run could
not report a verdict at all. Missing status is now an explicit failure.1 parent d58dc63 commit e60ce4f
1 file changed
Lines changed: 18 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
51 | 50 | | |
52 | 51 | | |
53 | 52 | | |
54 | 53 | | |
55 | 54 | | |
56 | | - | |
57 | 55 | | |
58 | 56 | | |
59 | 57 | | |
60 | | - | |
61 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
62 | 76 | | |
63 | 77 | | |
64 | 78 | | |
| |||
0 commit comments