Check failed writes

Author: kellerza

hass-addon-sunsynk-edge/CHANGELOG.md

@@ -2,9 +2,14 @@
 
 <https://github.com/kellerza/sunsynk/commits/>
 
-## Release 1.3.0
+## Unreleased
+
+All items below are changes since add-on **1.3.0**.
 
-All items below are changes since add-on **1.2.0**.
+- Failed Modbus writes no longer update the local register cache. #692
+- Fix AsyncCallback checks. #693
+
+## Release 1.3.0
 
 - Single-phase **Grid Trickle Feed power** number (register 206, −500…500 W).
 - mqtt-entity ≥ 1.2.5.
@@ -14,8 +19,6 @@ All items below are changes since add-on **1.2.0**.
 
 ## Release 1.2.0
 
-All items below are changes since add-on **1.1.1** (stable release on GitHub `main`).
-
 - tmodbus 0.6.0 - improved re-synchronization logic for RTU-streams that got out of sync.
 - Prefix **`PORT`** with **`pymodbus-`** to use the pymodbus Modbus backend (e.g.
   `pymodbus-tcp://host:502`, `pymodbus-/dev/ttyUSB0`). Default is tmodbus.
@@ -34,14 +37,10 @@ All items below are changes since add-on **1.1.1** (stable release on GitHub `ma
 
 ## Release 1.1.1
 
-All items below are changes since add-on **1.1.0**.
-
 - Removed leftover `DRIVER` option from the add-on schema.
 
 ## Release 1.1.0
 
-All items below are changes since add-on **1.0.0**.
-
 - **Breaking:** three-phase **Parallel Mode** select options are **Client** (was Master) and
   **Server** (was Slave). The inverter LCD may still say Master/Slave. Update automations that match
   the old strings.
@@ -74,8 +73,6 @@ All items below are changes since add-on **1.0.0**.
 
 ## Release 1.0.0
 
-All items below are changes since add-on **0.10.1**.
-
 ### Major changes
 
 The following are major changes, but should accept and convert older configuration:

src/ha_addon_sunsynk_multi/sensor_callback.py

@@ -89,10 +89,13 @@ async def callback_sensor(now: int) -> None:  # noqa: PLR0915 PLR0912
             if not isinstance(sensor, RWSensor):
                 continue
             await asyncio.sleep(0.1)
-            await ist.write_sensor(sensor, value)
-            await asyncio.sleep(0.05)
-            await ist.read_sensors(sensors=[sensor], msg=sensor.name)
-            sensors_to_publish.add(ist.ss[sensor.id])
+            try:
+                await ist.write_sensor(sensor, value)
+                await asyncio.sleep(0.05)
+                await ist.read_sensors(sensors=[sensor], msg=sensor.name)
+                sensors_to_publish.add(ist.ss[sensor.id])
+            except Exception as err:
+                _LOG.error("Failed to write %s=%s: %s", sensor.id, value, err)
 
         # add all read items
         for sec, srun in ist.sched.read.items():

src/sunsynk/sunsynk.py

@@ -181,7 +181,8 @@ async def write_sensor(
         for idx, addr in enumerate(sensor.address):
             if idx:
                 await asyncio.sleep(0.05)
-            await self.write_register(address=addr, value=regs[idx])
+            if not await self.write_register(address=addr, value=regs[idx]):
+                raise OSError(f"Failed to write register {addr}")
             self.state.registers[addr] = regs[idx]
 
     async def read_holding_registers(self, start: int, length: int) -> Sequence[int]:

src/tests/sunsynk/test_sunsynk.py

@@ -74,6 +74,24 @@ async def test_ss_write_sensor(
     assert "outside" in caplog.text
 
 
+@patch("sunsynk.Sunsynk.write_register", new_callable=AsyncMock)
+async def test_ss_write_sensor_raises_on_failed_write(
+    wreg: AsyncMock, state: InverterState
+) -> None:
+    """Failed write_register must not update the register cache (#692)."""
+    ss = _ss()
+    ss.state = state
+    sen = NumberRWSensor((1,), "s1")
+    state.track(sen)
+    wreg.return_value = False
+
+    with pytest.raises(OSError, match="Failed to write register 1"):
+        await ss.write_sensor(sen, 44)
+
+    assert state.registers == {}
+    wreg.assert_awaited_once_with(address=1, value=44)
+
+
 @patch("sunsynk.Sunsynk.read_holding_registers")
 @patch("sunsynk.Sunsynk.write_register")
 async def test_ss_write_sensor_bm(