serial-tcp

Author: kellerza

docs/modbus-connection-plan.md

@@ -127,7 +127,7 @@ ss = Sunsynk(unit=SolarmanUnit(host, port, dongle_serial_number, server_id=1))
 `from_url` parses the existing schemes:
 
 - `tcp://host:502` → `ModbusTcpParams` (native Modbus TCP)
-- `serial-tcp://host:port` → `ModbusTcpParams(..., framer="rtu")`
+- `serial-tcp://host:port` → `ModbusSerialParams(device="socket://host:port", framer="rtu")`
 - `udp://host:port` → `ModbusUdpParams`
 - `/dev/ttyUSB0` (or any path with no scheme) → `ModbusSerialParams`
 

docs/timeouts.md

@@ -169,10 +169,9 @@ two `MODBUS_ID`s share one `tcp://` PORT).
 
 ### `serial-tcp://` (RTU-over-TCP)
 
-Same as TCP for the socket side, but the framer is **RTU**. The gateway translates RTU frames on the
-RS485 side. Spacing and turnaround constraints from [Serial](#serial) apply
-**on the bus behind the gateway**; the default **0.05s** spacing helps gateways that forward
-requests immediately without pacing.
+Built as **`ModbusSerialParams(device="socket://host:port")`** (RTU over a TCP socket). The gateway
+translates RTU frames on the RS485 side. Spacing, **`connect_delay`**, and **disconnect-on-timeout**
+from [Serial](#serial) apply — the bus behind the gateway is still half-duplex RTU.
 
 If the gateway buffers poorly under rapid polling, prefer **`tcp://`** (native Modbus TCP) when the
 device supports it, or reduce batch size / read frequency.

hass-addon-sunsynk-edge/CHANGELOG.md

@@ -9,6 +9,8 @@ All items below are changes since add-on **1.3.0**.
 - Failed Modbus writes no longer update the local register cache. #692
 - Fix AsyncCallback checks. #693
 - Bump whenever to 0.11
+- `serial-tcp://` uses `ModbusSerialParams(socket://…)` (modbus-connection 4.12+); timeouts
+  disconnect like other serial links.
 
 ## Release 1.3.0
 

src/sunsynk/connection.py

@@ -31,7 +31,9 @@ def url_to_params(
             case "tcp":
                 return ModbusTcpParams(host=host, port=tcp_port)
             case "serial-tcp":
-                return ModbusTcpParams(host=host, port=tcp_port, framer="rtu")
+                # RTU-over-TCP is a serial link; ModbusTcpParams(framer=) is deprecated (4.12+)
+                sock = f"[{host}]:{tcp_port}" if ":" in host else f"{host}:{tcp_port}"
+                return ModbusSerialParams(device=f"socket://{sock}", framer="rtu")
             case "udp":
                 return ModbusUdpParams(host=host, port=tcp_port)
             case "serial-udp":

src/tests/sunsynk/test_connection.py

@@ -23,8 +23,11 @@ def test_url_to_params() -> None:
     assert url_to_params("tcp://1.2.3.4:502") == ModbusTcpParams(
         host="1.2.3.4", port=502
     )
-    assert url_to_params("serial-tcp://host:8899") == ModbusTcpParams(
-        host="host", port=8899, framer="rtu"
+    assert url_to_params("serial-tcp://host:8899") == ModbusSerialParams(
+        device="socket://host:8899", framer="rtu"
+    )
+    assert url_to_params("serial-tcp://[::1]:8899") == ModbusSerialParams(
+        device="socket://[::1]:8899", framer="rtu"
     )
     assert url_to_params("udp://host:502") == ModbusUdpParams(host="host", port=502)
     assert url_to_params("/dev/ttyUSB0", baudrate=19200) == ModbusSerialParams(
@@ -62,7 +65,11 @@ def test_open_connection_serial_spacing() -> None:
     serial = open_connection("/dev/ttyUSB0", timeout=5)
     assert serial._pacer._message_spacing == DEFAULT_MESSAGE_SPACING
     rtu_tcp = open_connection("serial-tcp://host:8899", timeout=5)
+    assert rtu_tcp._params == ModbusSerialParams(
+        device="socket://host:8899", framer="rtu"
+    )
     assert rtu_tcp._pacer._message_spacing == DEFAULT_MESSAGE_SPACING
+    assert rtu_tcp._connect_delay == 0.05
     no_gap = open_connection("/dev/ttyUSB0", timeout=5, message_spacing=0)
     assert no_gap._pacer._message_spacing == 0.0
     custom = open_connection("tcp://127.0.0.1:502", timeout=5, message_spacing=0.1)