Publish bizeros-knowledge web image to GHCR with the fork's source - #2
Merged
Merged
Conversation
Previously the Dockerfile re-cloned upstream logseq/logseq:master at build time, which discarded this fork's rebrand and made the produced image identical to vanilla Logseq. The publish workflow also tagged the image as logseq-webapp:latest and only ran on releases, so nothing was ever published for kelsi-bizer/bizeros-knowledge. Changes: - Dockerfile now COPYs the build context (this repo) instead of cloning upstream, so the rebranded sources are baked into the image. - Add .dockerignore to keep the build context lean (excludes mobile, docs, e2e suites, build outputs, .git). - Workflow now publishes to ghcr.io/<owner>/bizeros-knowledge with metadata-driven tags (latest on master, semver tags on releases, sha tags for traceability), runs on every push to master, and uses current major versions of docker/* actions. - Declare packages: write permission so GITHUB_TOKEN can push to GHCR.
PR #1's rebrand replaced two hardcoded "Logseq Sync" strings in settings.cljs with "BizerOS Knowledge Sync". The i18n lint allowlist only contained the old brand names, so bb lang:lint-hardcoded fails on master. Add "BizerOS Knowledge" and "BizerOS Knowledge Sync" alongside the existing Logseq entries — same justification (brand name displayed literally, intentionally not translated).
- src/test/frontend/context/i18n_test.cljs: English assertions for :help/about now expect "About BizerOS Knowledge". The Spanish assertion is unchanged because non-English dictionaries were not rebranded. - src/main/mobile/components/settings.cljs: rebrand the hardcoded "Logseq Sync" fallback to "BizerOS Knowledge Sync" to match the desktop settings component.
kelsi-bizer
marked this pull request as ready for review
May 6, 2026 16:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a working publish pipeline so
ghcr.io/kelsi-bizer/bizeros-knowledge:latestactually exists and contains the rebranded fork — not vanilla Logseq.Two real bugs in the existing setup blocked any image from being usable:
git clone -b master https://github.com/logseq/logseq.git .). Even when CI ran successfully, the image was vanilla Logseq with none of this fork's rebrand baked in.ghcr.io/<owner>/logseq-webapp:latestand only ran onrelease: released. Since no releases have been cut on this fork, nothing was ever published, and consumers looking forbizeros-knowledge:latestgot "denied invalid token".Changes
Dockerfile— replaces the upstream clone withCOPY . /dataso the build context (this fork's source, including the rebrand) is what gets compiled..dockerignore— new file. Keeps the build context lean by excludingnode_modules,static/,dist/,ios/,android/,docs/,cli-e2e/,clj-e2e/,.git/,.github/, etc. Without this,COPY . /datawould balloon the context..github/workflows/build-docker.ymlghcr.io/${{ github.repository_owner }}/bizeros-knowledge(waslogseq-webapp).master, on tags matchingv*, on releases, and on manual dispatch.docker/metadata-action@v5to compute tags:lateston default branch, semver from version tags, short-sha for traceability.permissions: packages: writesoGITHUB_TOKENcan push to GHCR.setup-qemu-action,setup-buildx-action,login-action,build-push-actionto current majors (the v1/v2 versions are years out of date and won't run on current runners reliably).Test plan
Build-Dockerworkflow runs on push tomasterghcr.io/kelsi-bizer/bizeros-knowledge:latestappears under the org's Packages tab and is pullabledocker run -p 8080:80 ghcr.io/kelsi-bizer/bizeros-knowledge:latest), and verify the served HTML<title>says "BizerOS Knowledge" (proves the rebrand made it into the image, not vanilla Logseq)v0.1.0tag and verify a semver-tagged image is published alongside:latestGenerated by Claude Code