Fix EditDistance crash with dense tensor inputs - #2973
Open
buildwithsuhana wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the EditDistance metric to support dense tensor inputs and adds a corresponding unit test. However, the reviewer noted that using tf.size(y_true) directly will cause a crash when y_true is a tf.RaggedTensor, which is the primary input format. A code suggestion was provided to robustly handle both dense and ragged tensors.
buildwithsuhana
marked this pull request as draft
August 20, 2026 16:15
buildwithsuhana
marked this pull request as ready for review
August 27, 2026 07:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR fixes a bug where EditDistance(normalize=True) would crash when provided with a dense 2D Tensor as input. The crash occurred because the metric attempted to access the flat_values attribute, which is only available on RaggedTensor.
I have replaced the y_true.flat_values access with tf.size(y_true), which works correctly for both dense and ragged tensors in TensorFlow. A new test case has been added to edit_distance_test.py to cover this scenario.
Colab Notebook
https://colab.research.google.com/drive/1qkcPI-JIlDcaHKVTO6yx8u-gbAjUp_Hs?usp=sharing
Checklist