Migrate Melgan Spectrogram Inversion to Keras3 - #2347
Open
maitry63 wants to merge 3 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the MelGAN spectrogram inversion example to Keras 3, replacing TensorFlow-specific operations and dependencies with Keras 3 ops and a custom WeightNormalization layer. Feedback highlights several issues: the WeightNormalization layer is missing dilation_rate support and a get_config method; the generator's upsampling blocks were incorrectly changed to Conv1D; redundant code was found in the MelSpec layer; and the discriminator's pooling size was altered, potentially impacting model architecture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Migrate the Melgan Spectrogram Inversion Tutorial to Keras 3.
Notebook - Colab