Remove stale exclusions for argpartition and cross tests - #39
Merged
Conversation
samudraneel05
force-pushed
the
test-update
branch
from
August 31, 2026 15:39
17edcd6 to
3ab236c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed excluding the
test_argpartitionandtest_crosstests since they work on mac and have been passing since the initial implementation. Both were excluded preemptively in the initial commit but the underlying ops (mx.argpartition and mx.cross) handle & work correctly.Verified locally.
Edit:
test_argpartitionwas originally removed from exclusions but again added as it fails on linux - mx.argpartition uses a different tie-breaking order than np.argpartition on the platform