Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
istftreturned an empty array wheneverfft_lengthwas 0 or 1 withcenter=True. The end of the slice was-(fft_length // 2), which is-0in that case, sox[..., start:0]kept nothing. jax counts back from the expected length instead,expected_output_len - (fft_length // 2), which this now matches.The
test_istft7andtest_istft8exclusions stay. Removing them passes on linux but fails on macOS, where the same input comes back as the right values interleaved with zeros,[v0, 0, v1, 0, ...]against[v0, v1, v2, ...]. That is a separate Metal only problem in the overlap and add path and it needs a machine with Metal to chase, so it is not in this PR.The other five istft exclusions also stay. Their mismatches are all inside the 5% of each boundary that
math_test.pyalready truncates for numpy, jax, torch and openvino, so they are the same boundary difference those backends have rather than anything wrong here. Adding mlx to that list is a keras change, not one for this repo.