Skip to content

Keep the istft slice from emptying when fft_length is 0 or 1 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarcosAsh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Keep the istft slice from emptying when fft_length is 0 or 1 #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f06c79
Keep the istft slice from emptying when fft_length is 0 or 1
MarcosAsh Aug 31, 2026
408a832
Keep the istft exclusions, Metal fails them for a second reason
MarcosAsh Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion keras_mlx/src/ops/math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,10 @@ def istft(
if length is not None:
end = start + length
elif center is True:
end = -(fft_length // 2)
# Counting back from the expected length rather than from the end of
# the array. A negative index would be -0 when fft_length is 0 or 1,
# which empties the slice instead of keeping everything.
end = expected_output_len - (fft_length // 2)
else:
end = expected_output_len
return x[..., start:end]
Expand Down
Loading