change(developer): move touch layout editor to typescript - #16520
Open
mcdurdin wants to merge 5 commits into
Open
change(developer): move touch layout editor to typescript#16520mcdurdin wants to merge 5 commits into
mcdurdin wants to merge 5 commits into
Conversation
keymanapp-test-bot
Bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions
Results Template |
github-actions
Bot
added
developer/
developer/ide/
change
mcdurdin
marked this pull request as draft
September 3, 2026 14:40
mcdurdin
force-pushed
the
change/developer/touch-layout-editor-typescript
branch
3 times, most recently
from
September 5, 2026 03:55
b5f6a2b to
321c0fa
Compare
mcdurdin
force-pushed
the
change/developer/touch-layout-editor-typescript
branch
2 times, most recently
from
September 7, 2026 04:33
5d01473 to
0fb009b
Compare
mcdurdin
force-pushed
the
change/developer/touch-layout-reorganize-files
branch
from
September 7, 2026 04:35
2d198a3 to
76b36e8
Compare
Minimal changeover to esm, use tsc to build. Builds and runs. Installer will still include source files and the editor should be moved outside of the xml/ folder later.
Note: doesn't build, just for history
Make minimal changes to Touch Layout Editor source files in order to build with Typescript with noImplicitAny=false (to be cleaned up later). Also make source files accessible through the web server for Developer Console use.
Take the @types/jquery and @types/jqueryui packages out of the devDependencies and place the index.d.[c]ts files into the ext folder. This is needed because of fragility elsewhere with implicitly imported types, which is described for resolution in #16535. Keeping this as a separate commit as preference would be to have these dependencies managed through npm long-term. See-also: #16535
mcdurdin
force-pushed
the
change/developer/touch-layout-editor-typescript
branch
from
September 7, 2026 04:50
0fb009b to
d86b2b5
Compare
…ayout editor In order to resolve initialization order (see instigating property `builder.lastPresentations`), split all constants into a separate object `builderConstants`, inverting the dependency, which is both cleaner and the first step of removing the multi-module initialization of a single `builder` variable.
mcdurdin
commented
Sep 7, 2026
Member
Author
There was a problem hiding this comment.
Unused source file, detected during renames
mcdurdin
marked this pull request as ready for review
September 7, 2026 06:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change in
threefive commits. It will be easiest to review these changes commit-by-commit and with whitespace changes ignored.31999ce: Minimal changeover to esm, use tsc to build. Builds and runs. Installer will still include source files and the editor should be moved outside of the xml/ folder later.
173e2ec: Rename touch layout editor .js to .ts - note: doesn't build, just for history, and simplicity of review.
c1abf5f: Make minimal changes to Touch Layout Editor source files in order to build with Typescript with noImplicitAny=false (to be cleaned up later). Also make source files accessible through the web server for Developer Console use.
d86b2b5: moves jquery and jqueryui out of node_modules, due to implicit import conflicts in other Typescript modules in /web (long term resolution proposed in maint(common): consider declaring used types/libs in each tsconfig.json #16535)
98fee32: fixup initialization order for constants (triggered by recent change fix(developer): remember presentation and layer when switching platforms in touch layout editor #16509, which prompted the refactor when it was merged into this branch)
User Testing
TEST_REGRESSION: Open the touch layout editor, press F12 to view Developer Console. Run through all the standard operations of the touch layout editor and verify no errors in Developer Console and that all operations work correctly.
Things to test:
You may wish to compare behaviour against the existing alpha release version.