fix(web): allow to set default keyboard to 'off' - #16524
Open
ermshiperete wants to merge 1 commit into
Open
Conversation
keymanapp-test-bot
Bot
added
the
user-test-missing
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined Test Artifacts |
ermshiperete
force-pushed
the
fix/web/16080_kbdoff
branch
from
September 3, 2026 17:12
5d4a63b to
466b822
Compare
ermshiperete
force-pushed
the
fix/web/16080_kbdoff
branch
from
September 4, 2026 20:30
466b822 to
01921a2
Compare
ermshiperete
changed the base branch from
chore/web/typesInTest
to
refactor/web/funcscope
September 4, 2026 20:32
ermshiperete
force-pushed
the
fix/web/16080_kbdoff
branch
from
September 4, 2026 21:25
01921a2 to
a21df46
Compare
ermshiperete
force-pushed
the
fix/web/16080_kbdoff
branch
2 times, most recently
from
September 7, 2026 17:19
96c527c to
9de509a
Compare
ermshiperete
commented
Sep 7, 2026
| } | ||
|
|
||
| test.describe.skip('First example from the guide', function () { | ||
| test.describe('First example from the guide', function () { |
Contributor
Author
There was a problem hiding this comment.
The guide-examples e2e tests are re-enabled; if it turns out that they're still not stable then we can disable them again.
ermshiperete
force-pushed
the
fix/web/16080_kbdoff
branch
from
September 8, 2026 09:20
9de509a to
f82c68d
Compare
ermshiperete
commented
Sep 8, 2026
|
|
||
| languageMenu.lgList.style.display='none'; //still allows blank menu momentarily on selection | ||
| languageMenu.keyman.contextManager.activateKeyboard(entry.kn, entry.kc,true); | ||
| languageMenu.keyman.contextManager.restoreLastActiveTextStore(); |
Contributor
Author
There was a problem hiding this comment.
This is already done in activateKeyboard, so there's no need to do it twice (especially since activateKeyboard is async, so this call could possibly work with outdated data...)
ermshiperete
marked this pull request as ready for review
September 8, 2026 09:55
The parameters for `setKeyboardForControl` basically have three different modes: - an id of a keyboard/language to set that keyboard, enabling independent keyboard mode - empty string to set the system keyboard, enabling independent keyboard mode - `null` to disable independent keyboard mode. Our previous code didn't properly handle the last two modes. This change fixes the problems and also clarifies and updates the documentation. Also included is an improvement to the guide-examples e2e tests that now wait until all keyboards are loaded (which may fix #16167). Partially drafted by kilo.ai. Fixes: #16080 Build-bot: skip release:web
ermshiperete
force-pushed
the
fix/web/16080_kbdoff
branch
from
September 8, 2026 09:56
f82c68d to
4d7867e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parameters for
setKeyboardForControlbasically have three different modes: - an id of a keyboard/language to set that keyboard, enabling independent keyboard mode - empty string to set the system keyboard, enabling independent keyboard mode -nullto disable independent keyboard mode.Our previous code didn't properly handle the last two modes. This change fixes the problems and also clarifies and updates the documentation.
Also included is an improvement to the guide-examples e2e tests that now wait until all keyboards are loaded (which may fix #16167).
Partially drafted by kilo.ai.
Fixes: #16080
Build-bot: skip release:web