Skip to content

Commit c096562

Browse files
committed
Fix RecordNotFound message format assertion for Rails 7.2
Rails 7.2 quotes String id values in ActiveRecord::RecordNotFound's message (e.g. 'id'="60" instead of 'id'=60). Update the expected flash message accordingly in test_should_delete_allowed_user.
1 parent dfaa60a commit c096562

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

test/functional/kaui/admin_allowed_users_controller_test.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,9 @@ class AdminAllowedUsersControllerTest < Kaui::FunctionalTestHelper
134134

135135
# should respond with an error if tried to delete again
136136
delete :destroy, params: { id: }
137-
assert_equal "Error: Couldn't find Kaui::AllowedUser with 'id'=#{id}", flash[:error]
137+
# Rails 7.2 quotes the id value in ActiveRecord::RecordNotFound's message
138+
# (e.g. 'id'="60" instead of 'id'=60), since the id here is a String.
139+
assert_equal "Error: Couldn't find Kaui::AllowedUser with 'id'=\"#{id}\"", flash[:error]
138140
assert_response :redirect
139141
# validate redirect path
140142
assert response_path.include?('/kaui/home'), "#{response_path} is expected to contain '/kaui/home'"

test/functional/kaui/functional_test_helper_nosetup.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class FunctionalTestHelperNoSetup < ActionController::TestCase
1616
# body gets parsed as multipart. Clear it before every request; #process re-sets it as
1717
# needed for whichever request is actually being made.
1818
def process(*, **)
19-
@request.delete_header('CONTENT_TYPE') if @request
19+
@request&.delete_header('CONTENT_TYPE')
2020
super
2121
end
2222

0 commit comments

Comments
 (0)