Merge pull request #19 from tungleduyxyz/kaui_4.8

Added new rubocop extensions

Author: tungleduyxyz

.rubocop.yml

@@ -1,3 +1,9 @@
+require:
+  - rubocop-performance
+  - rubocop-rails
+  - rubocop-rspec
+  - rubocop-thread_safety
+
 inherit_mode:
   merge:
     - Exclude
@@ -8,6 +14,7 @@ AllCops:
     - 'app/controllers/deposit/engine_controller.rb' # Too much magic going on
   NewCops: enable
   SuggestExtensions: false
+  TargetRubyVersion: 3.2
 
 Gemspec/RequiredRubyVersion:
   Enabled: false
@@ -51,3 +58,34 @@ Style/Documentation:
 
 Style/EmptyElse:
   EnforcedStyle: empty
+
+# Rails cops
+Rails:
+  Enabled: true
+
+Rails/I18nLocaleTexts:
+  Enabled: false
+
+Rails/SkipsModelValidations:
+  Enabled: false
+
+# RSpec cops
+RSpec:
+  Enabled: true
+
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/ExampleLength:
+  Enabled: false
+
+# Performance cops
+Performance:
+  Enabled: true
+
+# Thread Safety cops
+ThreadSafety:
+  Enabled: true
+
+ThreadSafety/ClassAndModuleAttributes:
+  Enabled: false

Gemfile

@@ -24,6 +24,10 @@ group :development do
   gem 'puma'
   gem 'rake'
   gem 'rubocop'
+  gem 'rubocop-performance'
+  gem 'rubocop-rails'
+  gem 'rubocop-rspec'
+  gem 'rubocop-thread_safety'
   gem 'simplecov'
   gem 'sprockets-rails'
 end

app/controllers/deposit/collection_controller.rb

@@ -126,7 +126,7 @@ def account_invoices
       pages.each { |page| json[:data] << formatter.call(page) }
 
       respond_to do |format|
-        format.json { render json: json }
+        format.json { render json: }
       end
     end
 

config/routes.rb

@@ -6,7 +6,7 @@
   resources :collection, only: [:index]
 
   scope '/collection' do
-    match '/record' => 'collection#record_payments', :via => :post, :as => 'do_record_payments'
-    match '/account_invoices' => 'collection#account_invoices', :via => :get, :as => 'account_invoices'
+    post '/record' => 'collection#record_payments', :as => 'do_record_payments'
+    get '/account_invoices' => 'collection#account_invoices', :as => 'account_invoices'
   end
 end

lib/deposit/client.rb

@@ -17,17 +17,17 @@ def record_payments(account_id, effective_date, payment_reference_number, deposi
             effectiveDate: effective_date,
             paymentReferenceNumber: payment_reference_number,
             depositType: deposit_type,
-            payments: payments
+            payments:
           }.to_json
 
           path = "#{KILLBILL_DEPOSIT_PREFIX}/record"
           response = KillBillClient::API.post path,
                                               body,
                                               {},
                                               {
-                                                user: user,
-                                                reason: reason,
-                                                comment: comment
+                                                user:,
+                                                reason:,
+                                                comment:
                                               }.merge(options)
           response.body
         end

test/test_helper.rb

@@ -8,7 +8,7 @@
 Minitest.backtrace_filter = Minitest::BacktraceFilter.new
 
 # Load support files
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].sort.each { |f| require f }
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
 # Load fixtures from the engine
 if ActiveSupport::TestCase.respond_to?(:fixture_path=)