fixed some problems, when compiling with very strict compile options

[BruceBlank]

A have split the original commit in to two: This fix will avoid warnings when compiling

[BruceBlank]

Hi all,

you can think of this fix as a sort of code-style-correction, But as this projects code will be bound into other code by an #include directive, it is more than that. If you work on a project, which demands very strict compile options (-Wall -Wextra -Wshadow -Werror), as i do, you have the problem, that the code will not compile, without this fix or without another work around.

greetings
Bruce

[toch]

Thanks @BruceBlank. Sorry for the delay.

I understand your case. However, code convention is there first for readability. I don't want to change the code convention just to comply with one case based on one specific compiler, especially if the change is less readable or introduce another issue:

• IMK, it's a bad practice to start a variable with _ in C++ as it could be reserved to the implementation in a few cases. I would prefer another option to fix the warning.
• The commenting of the parameter is debatable. On one hand, it indicates the parameter is not used, on another hand, if it's useless, why keeping it?

Why don't use pragma to disable warning when including tap.h?
Could you tell me which compiler and version do you use?

[kinow]

ping @BruceBlank

[BruceBlank]

Hi,

sorry for the delay: We use gcc version 4.8.5 (Ubuntu 4.8.5-1ubuntu1).

greetings
Bruce

[toch]

@BruceBlank What about using the following pragma to disable the warning on tap.h?

For instance

#pragma GCC diagnostic push 
#pragma GCC diagnostic ignored "-Wshadow"
#pragma GCC diagnostic ignored "-Wunused-variable"
#include <tap.h>
#pragma GCC diagnostic pop

not all diagnostic can be ignored, but I think your case should be covered. As the doc says:

Note that not all diagnostics are modifiable; at the moment only warnings (normally controlled by ‘-W...’) can be controlled, and not all of them. Use -fdiagnostics-show-option to determine which diagnostics are controllable and which option controls them.

[BruceBlank]

@toch Thank you for your advice. I will try it.

[toch]

Keep me informed. if it works, it's a nice addition to our documentation I think.