Skip to content

Commit e618e25

Browse files
rimoliclaude
andcommitted
Let the tests run in the continuous integration
The workflow installed pytest 6.2.5 and a current pytest-cov, then the requirements pinned tox 3.14, whose pluggy < 1 requirement downgraded pluggy to 0.13; pytest-cov then failed to load ("unexpected keyword argument 'wrapper'") and no test ran. The workflow installs the current pytest, tox is no longer a requirement of the package (nothing imports it; tox.ini stays for local use), and the jobs of the test matrix no longer cancel each other when one fails, so that every platform reports its own result. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
1 parent f6f2543 commit e618e25

3 files changed

Lines changed: 6 additions & 2 deletions

File tree

‎.github/workflows/python_package.yaml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ jobs:
88

99
runs-on: ${{ matrix.os }}
1010
strategy:
11+
fail-fast: false
1112
matrix:
1213
python-version: [3.9, '3.10', '3.11', '3.12']
1314
os: ['ubuntu-latest', 'macos-latest', 'windows-latest']
@@ -30,7 +31,7 @@ jobs:
3031
run: |
3132
python -m pip install --upgrade pip
3233
pip install setuptools wheel
33-
pip install flake8 pytest==6.2.5 pytest-cov coveralls
34+
pip install flake8 pytest pytest-cov coveralls
3435
- name: Install package requirements
3536
run: pip install -r requirements.txt
3637
- name: Install package

‎CHANGELOG.rst‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,10 @@ Fixed
134134

135135
Changed
136136
'''''''
137+
- The continuous integration installs the current pytest and no longer
138+
installs tox from the requirements: the pinned tox 3.14 forced an old
139+
pluggy that the current pytest-cov cannot load, so no test could run.
140+
The jobs of the test matrix no longer cancel each other on a failure.
137141
- The facets of the triangular and tetrahedral meshes created from a
138142
polygonal mesh are sorted (nodes in ascending order within a facet,
139143
facets in lexicographic order), whatever the mesher. Triangle and TetGen

‎requirements.txt‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,5 @@ pyvoro-mmalahe==1.3.4
99
scipy>=1.10.1
1010
setuptools>=70.0.0
1111
xmltodict==0.12.0
12-
tox==3.14.0
1312
lsq-ellipse==2.0.1
1413
zipp>=3.19.1 # not directly required, pinned by Snyk to avoid a vulnerability

0 commit comments

Comments
 (0)